Support a Configurable syslog Maximum Message Size for HAProxy #1037
Conversation
|
/cc @arjunrn |
operator/v1/types_ingress.go
Outdated
| @@ -773,6 +773,15 @@ type SyslogLoggingDestinationParameters struct { | |||
| // +kubebuilder:validation:Enum=kern;user;mail;daemon;auth;syslog;lpr;news;uucp;cron;auth2;ftp;ntp;audit;alert;cron2;local0;local1;local2;local3;local4;local5;local6;local7 | |||
| // +optional | |||
| Facility string `json:"facility,omitempty"` | |||
|
|
|||
| // maxlength refers to the maximum length of the syslog message | |||
There was a problem hiding this comment.
| // maxlength refers to the maximum length of the syslog message | |
| // maxLength is the maximum length of the syslog message |
operator/v1/types_ingress.go
Outdated
| // +kubebuilder:validation:Optional | ||
| // +kubebuilder:validation:Maximum=4096 | ||
| // +optional | ||
| MaxLength uint32 `json:"maxlength"` |
There was a problem hiding this comment.
You should also specify a default value for the MaxLength.
| // | ||
| // +kubebuilder:validation:Optional | ||
| // +kubebuilder:validation:Maximum=4096 | ||
| // +kubebuilder:default=1024 |
There was a problem hiding this comment.
Should we set a reasonable minimum value, or is it reasonable to specify 0?
There was a problem hiding this comment.
According to the RFC-5424, 480 can be set as a reasonable minimum length. WDYT ?
|
Thanks! |
|
/assign @knobunc |
operator/v1/types_ingress.go
Outdated
| // +kubebuilder:validation:Minimum=480 | ||
| // +kubebuilder:default=1024 | ||
| // +optional | ||
| MaxLength uint32 `json:"maxLength"` |
There was a problem hiding this comment.
would add omitempty to avoid accidently transferring 0.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Miciah, sairameshv, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
This change includes an addition of a new parameter to the syslog logging destination parameters of an Ingress operator.