Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change the ResourceGroupID to optional on alibabacloud provider #1080

Merged
merged 1 commit into from Dec 10, 2021
Merged

change the ResourceGroupID to optional on alibabacloud provider #1080

merged 1 commit into from Dec 10, 2021

Conversation

BSWANG
Copy link
Contributor

@BSWANG BSWANG commented Dec 9, 2021

The ResourceGroupID is not required, so change the ResourceGroupID to optional.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 9, 2021

Hi @BSWANG. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 9, 2021
@BSWANG BSWANG changed the title change the ResourceGroupID to optional change the ResourceGroupID to optional on alibabacloud provider Dec 9, 2021
@BSWANG BSWANG changed the title change the ResourceGroupID to optional on alibabacloud provider [WIP]change the ResourceGroupID to optional on alibabacloud provider Dec 9, 2021
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 9, 2021
@BSWANG
change the ResourceGroupID to optional
5f016b9 
The `ResourceGroupID` is not required, so change the `ResourceGroupID` to optional.
@BSWANG BSWANG changed the title [WIP]change the ResourceGroupID to optional on alibabacloud provider change the ResourceGroupID to optional on alibabacloud provider Dec 9, 2021
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 9, 2021
@kwoodson
Copy link
Contributor

kwoodson commented Dec 9, 2021

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 9, 2021
@bparees
Copy link
Contributor

bparees commented Dec 10, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 10, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 10, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, BSWANG

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 10, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 10, 2021

@BSWANG: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit a0259ee into openshift:master Dec 10, 2021
sttts
sttts reviewed Dec 10, 2021
View reviewed changes
config/v1/types_infrastructure.go
// +required
ResourceGroupID string `json:"resourceGroupID"`
// +optional
ResourceGroupID string `json:"resourceGroupID,omitempty"`
Copy link
Contributor

@sttts sttts Dec 10, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you remove the kubebuilder pattern tag? It must stay.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving from required to optional break downgrades. Is that considered?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving from required to optional break downgrades. Is that considered?

this is the first release of the api

@BSWANG BSWANG deleted the patch-1 branch December 15, 2021 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sttts sttts sttts left review comments

@bparees bparees bparees left review comments

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@knobunc knobunc Awaiting requested review from knobunc

Assignees

@bparees bparees

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@BSWANG @kwoodson @bparees @sttts @openshift-merge-robot