Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DNS-over-TLS related types #1110

Merged
merged 1 commit into from Apr 1, 2022
Merged

Add DNS-over-TLS related types #1110

merged 1 commit into from Apr 1, 2022

Conversation

brandisher
Copy link
Contributor

@brandisher brandisher commented Feb 2, 2022 •
edited

Enhancement: openshift/enhancements#987

This PR is intended to add the necessary API changes to support DNS-over-TLS for the default cluster-dns.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 2, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 2, 2022
@brandisher brandisher force-pushed the dns-over-tls-forwardplugin-upstreamresolvers branch from 22496ef to ad5530f Compare February 2, 2022 15:56
@brandisher
Copy link
Contributor Author

/test all

@brandisher
Copy link
Contributor Author

/test verify

@brandisher brandisher force-pushed the dns-over-tls-forwardplugin-upstreamresolvers branch from ad5530f to 090cac9 Compare February 2, 2022 18:35
@brandisher
Copy link
Contributor Author

/test all

@brandisher brandisher force-pushed the dns-over-tls-forwardplugin-upstreamresolvers branch from 090cac9 to 72f7836 Compare February 22, 2022 20:04
@brandisher
Copy link
Contributor Author

/test all

@brandisher brandisher force-pushed the dns-over-tls-forwardplugin-upstreamresolvers branch 2 times, most recently from 72f7836 to 4f656bb Compare February 22, 2022 22:30
@brandisher
Copy link
Contributor Author

/test all

@brandisher brandisher force-pushed the dns-over-tls-forwardplugin-upstreamresolvers branch from 4f656bb to 99a25ad Compare March 1, 2022 16:36
@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 1, 2022
@brandisher brandisher force-pushed the dns-over-tls-forwardplugin-upstreamresolvers branch from 99a25ad to d7711b4 Compare March 1, 2022 16:44
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 1, 2022
@brandisher
Copy link
Contributor Author

/uncc @smarterclayton @sjenning
/cc @deads2k @Miciah

@openshift-ci openshift-ci bot requested review from deads2k and Miciah and removed request for sjenning and smarterclayton March 1, 2022 16:52
@brandisher brandisher marked this pull request as ready for review March 1, 2022 16:52
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 1, 2022
@openshift-ci openshift-ci bot requested review from bparees and eparis March 1, 2022 16:53
deads2k
deads2k reviewed Mar 3, 2022
View reviewed changes
operator/v1/types_dns.go Outdated Show resolved Hide resolved
deads2k
deads2k reviewed Mar 3, 2022
View reviewed changes
operator/v1/types_dns.go Outdated Show resolved Hide resolved
deads2k
deads2k reviewed Mar 3, 2022
View reviewed changes
operator/v1/types_dns.go Outdated Show resolved Hide resolved
Miciah
Miciah reviewed Mar 29, 2022
View reviewed changes
operator/v1/types_dns.go Outdated Show resolved Hide resolved
Miciah
Miciah reviewed Mar 29, 2022
View reviewed changes
operator/v1/types_dns.go Outdated Show resolved Hide resolved
Miciah
Miciah reviewed Mar 29, 2022
View reviewed changes
operator/v1/types_dns.go Outdated Show resolved Hide resolved
JoelSpeed
JoelSpeed reviewed Mar 30, 2022
View reviewed changes
operator/v1/types_dns.go Outdated Show resolved Hide resolved
operator/v1/types_dns.go Show resolved Hide resolved
@brandisher brandisher force-pushed the dns-over-tls-forwardplugin-upstreamresolvers branch from b2dc01c to a548617 Compare March 30, 2022 17:11
JoelSpeed
JoelSpeed reviewed Mar 30, 2022
View reviewed changes
Copy link
Contributor

@JoelSpeed JoelSpeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates @brandisher

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 30, 2022
@brandisher brandisher force-pushed the dns-over-tls-forwardplugin-upstreamresolvers branch from a548617 to b13165c Compare March 30, 2022 20:33
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 30, 2022
JoelSpeed
JoelSpeed reviewed Mar 31, 2022
View reviewed changes
Copy link
Contributor

@JoelSpeed JoelSpeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@deads2k
Copy link
Contributor

deads2k commented Mar 31, 2022

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 31, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 31, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brandisher, deads2k, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 31, 2022
@melvinjoseph86
Copy link

/qe-approved

@melvinjoseph86
Copy link

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Apr 1, 2022
@CFields651
Copy link

/label px-approved

@openshift-ci openshift-ci bot added the px-approved Signifies that Product Support has signed off on this PR label Apr 1, 2022
@ahardin-rh
Copy link

/label docs-approved

@openshift-ci openshift-ci bot added the docs-approved Signifies that Docs has signed off on this PR label Apr 1, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 1, 2022

@brandisher: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit f2b05cc into openshift:master Apr 1, 2022
@brandisher brandisher deleted the dns-over-tls-forwardplugin-upstreamresolvers branch April 1, 2022 18:54
@brandisher brandisher mentioned this pull request Apr 20, 2022
Merged
@brandisher brandisher mentioned this pull request May 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Miciah Miciah Miciah left review comments

@deads2k deads2k deads2k left review comments

@JoelSpeed JoelSpeed JoelSpeed left review comments

@bparees bparees Awaiting requested review from bparees

@eparis eparis Awaiting requested review from eparis

Assignees

@deads2k deads2k

@JoelSpeed JoelSpeed

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@brandisher @deads2k @melvinjoseph86 @CFields651 @ahardin-rh @Miciah @bparees @JoelSpeed @openshift-merge-robot