-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 2074243: DefaultPlacement
allow empty enum value and remove default
#1172
Conversation
The `DefaultPlacement` config status field should allow the `""` value to be used during an Update for this subresource. This should allow the status subresource to be updated even when `DefaultPlacement` has an empty value. Also removed the `kubebuilder:default:="Workers"` specifier because the controller already regards an empty value as `"Workers"`, there's no need for it to be explicitly set when omitted.
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, omertuc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
DefaultPlacement
allow empty enum value and remove defaultDefaultPlacement
allow empty enum value and remove default
@omertuc: This pull request references Bugzilla bug 2074243, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@Miciah: This pull request references Bugzilla bug 2074243, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@omertuc: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/bugzilla refresh |
@wking: This pull request references Bugzilla bug 2074243, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@omertuc: All pull requests linked via external trackers have merged: Bugzilla bug 2074243 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The
DefaultPlacement
config status field should allow the""
valueto be used during an Update for this subresource. This should allow the
status subresource to be updated even when
DefaultPlacement
has anempty value.
Also removed the
kubebuilder:default:="Workers"
specifier because thecontroller already regards an empty value as
"Workers"
, there's noneed for it to be explicitly set when omitted.