fix: rename operatorhub crd manifest file #1178
Conversation
Rename the OperatorHub CRD manifest file to denote the SLO it belongs to: the marketplace-operator. The current name causes the CRD to be applied during cluster bootstrapping -- as a part of the cluster-config-operator -- despite attempts to disable the marketplace component. Signed-off-by: Nick Hale <njohnhale@gmail.com>
|
@njhale: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Sets up operator-framework/operator-marketplace#467, transferring the manifest from the config operator to the marketplace operator.
/lgtm
|
/approve want to make sure we orchestrate the 3 PRs to land as closely together as possible, lest someone else vendor bump the config-operator after this merges and we lose the resource entirely in an intermediary payload. |
openshift-ci
bot
added
the
do-not-merge/hold
bparees
added
qe-approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bparees, njhale, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
applying docs/qe/px labels as this has no effect on product function |
operator-framework/operator-marketplace#467 merged, I think we're good to merge this then open up the vendor bump for the config-operator |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
… is enabled Like 6d1143a (cli: remove metal3 CRDs when capabilities are none, 2022-04-08, openshift#26998), but catching up to openshift/api@d905557541 (fix: rename operatorhub crd manifest file, 2022-04-12, openshift/api#1178) and operator-framework/operator-marketplace@eca17739ed (chore(modules): bump openshift/api for new operatorhub crd, 2022-05-02, operator-framework/operator-marketplace#472) dancing the OperatorHub CRD over to the marketplace operator, and making it part of the 'marketplace' cluster-version capability.
… is enabled Like 6d1143a (cli: remove metal3 CRDs when capabilities are none, 2022-04-08, openshift#26998), but catching up to openshift/api@d905557541 (fix: rename operatorhub crd manifest file, 2022-04-12, openshift/api#1178) and operator-framework/operator-marketplace@eca17739ed (chore(modules): bump openshift/api for new operatorhub crd, 2022-05-02, operator-framework/operator-marketplace#472) dancing the OperatorHub CRD over to the marketplace operator, and making it part of the 'marketplace' cluster-version capability.
Rename the OperatorHub CRD manifest file to denote the SLO it belongs
to: the marketplace-operator. The current name causes the CRD to be
applied during cluster bootstrapping -- as a part of the
cluster-config-operator -- despite attempts to disable the
"marketplace" capability to which the CRD belongs.
Signed-off-by: Nick Hale njohnhale@gmail.com
cc @wking @bparees @perdasilva
Supersedes #1177