-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(modules): bump openshift/api for new operatorhub crd #472
chore(modules): bump openshift/api for new operatorhub crd #472
Conversation
- Drop unnecessary replaces directives - Bump openshift/api to include the new OperatorHub CRD manifest (w/ marketplace capability annotation) - Update ./vendor Signed-off-by: Nick Hale <njohnhale@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, those dependencies were over a year old. Do we know if there will be any unintended side effects from this? Should probably keep a close eye on the E2E suite just in case. Regardless, this looks good to me.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: njhale, tylerslaton The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There could be. Hopefully our e2e suite will catch this. Already seeing okd-e2e-gcp failing, but I'm not confident it's related. I'll be on the lookout for subsequent failures. /retest-required |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest-required Please review the full test history for this PR and help us cut down flakes. |
@njhale: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
… is enabled Like 6d1143a (cli: remove metal3 CRDs when capabilities are none, 2022-04-08, openshift#26998), but catching up to openshift/api@d905557541 (fix: rename operatorhub crd manifest file, 2022-04-12, openshift/api#1178) and operator-framework/operator-marketplace@eca17739ed (chore(modules): bump openshift/api for new operatorhub crd, 2022-05-02, operator-framework/operator-marketplace#472) dancing the OperatorHub CRD over to the marketplace operator, and making it part of the 'marketplace' cluster-version capability.
… is enabled Like 6d1143a (cli: remove metal3 CRDs when capabilities are none, 2022-04-08, openshift#26998), but catching up to openshift/api@d905557541 (fix: rename operatorhub crd manifest file, 2022-04-12, openshift/api#1178) and operator-framework/operator-marketplace@eca17739ed (chore(modules): bump openshift/api for new operatorhub crd, 2022-05-02, operator-framework/operator-marketplace#472) dancing the OperatorHub CRD over to the marketplace operator, and making it part of the 'marketplace' cluster-version capability.
Description of the change:
marketplace capability annotation)
Motivation for the change:
The current version of OpenShift API being vendored contains an old v1beta1 CRD manifest, missing the marketplace capability annotation.
Blocks openshift/cluster-config-operator#245