Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed the workerlatencyprofile status from the config node CR #1187

Merged

Conversation

sairameshv
Copy link
Member

Removed the workerlatencyprofile status related data structures from the config node CRD.

The status of the worker latency profile will be updated as part of the respective operator i.e KubeAPIServer operator, Kube Controller Manager Operator whenever there is a change in the confi node custom resource.

@openshift-ci openshift-ci bot requested a review from bparees May 2, 2022 08:44
@sairameshv
Copy link
Member Author

cc: @harche @swghosh

@openshift-ci openshift-ci bot requested a review from sttts May 2, 2022 08:44
@harche
Copy link
Contributor

harche commented May 2, 2022

/hold until @soltysh reviews it.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 2, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 2, 2022

@sairameshv: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@harche
Copy link
Contributor

harche commented May 4, 2022

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 4, 2022
@harche
Copy link
Contributor

harche commented May 4, 2022

Sorry, it was a different PR I wanted to cancel hold. Adding it back until this one is reviewed by Maciej.

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 4, 2022
Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 4, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 4, 2022
@soltysh
Copy link
Member

soltysh commented May 4, 2022

/label px-approved
/label docs-approved
/label qe-approved

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 4, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sairameshv, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added px-approved Signifies that Product Support has signed off on this PR docs-approved Signifies that Docs has signed off on this PR approved Indicates a PR has been approved by an approver from all required OWNERS files. qe-approved Signifies that QE has signed off on this PR labels May 4, 2022
@openshift-merge-robot openshift-merge-robot merged commit 6f735e7 into openshift:master May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants