Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the references of workerlatencyprofile status #1108

Merged
merged 1 commit into from
May 11, 2022
Merged

Remove the references of workerlatencyprofile status #1108

merged 1 commit into from
May 11, 2022

Conversation

sairameshv
Copy link
Member

The worker latency profile status related references have been removed from the config node CRD and hence this EP is updated accordingly.

@openshift-ci openshift-ci bot requested review from celebdor and mfojtik May 5, 2022 16:16
@sairameshv
Copy link
Member Author

cc: @harche @rphillips @swghosh

@dhellmann
Copy link
Contributor

/override ci/prow/markdownlint

The template changed, but you don't have to deal with that in this update.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 5, 2022

@dhellmann: Overrode contexts on behalf of dhellmann: ci/prow/markdownlint

In response to this:

/override ci/prow/markdownlint

The template changed, but you don't have to deal with that in this update.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sairameshv
Copy link
Member Author

/override ci/prow/markdownlint

The template changed, but you don't have to deal with that in this update.

Thanks for that :)

@harche
Copy link
Contributor

harche commented May 6, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 6, 2022
@harche
Copy link
Contributor

harche commented May 6, 2022

/cc @soltysh

@openshift-ci openshift-ci bot requested a review from soltysh May 6, 2022 05:12
soltysh
soltysh requested changes May 6, 2022
View reviewed changes
Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're removing this we're replacing that with something else, I'm missing that part in this update.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 7, 2022
@sairameshv
Copy link
Member Author

If we're removing this we're replacing that with something else, I'm missing that part in this update.

Yeah, True. Updated accordingly

@sairameshv sairameshv requested a review from soltysh May 7, 2022 01:49
@sairameshv
Copy link
Member Author

/override ci/prow/markdownlint

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 7, 2022

@sairameshv: sairameshv unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file.

In response to this:

/override ci/prow/markdownlint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dhellmann
Copy link
Contributor

/override ci/prow/markdownlint

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 9, 2022

@dhellmann: Overrode contexts on behalf of dhellmann: ci/prow/markdownlint

In response to this:

/override ci/prow/markdownlint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

soltysh
soltysh approved these changes May 10, 2022
View reviewed changes
Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor typos nits, rest lgtm
/approve

enhancements/worker-latency-profile/worker-latency-profile.md Outdated
### Status Updates

The progress of the WorkerLatencyProfile rollout can be tracked in the following ways.
* The Machine Config Operator generates events incase of any rollout failures. The "worker" machine config pool gets updated incase of a successful WorkerLatencyProfile rollout.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* The Machine Config Operator generates events incase of any rollout failures. The "worker" machine config pool gets updated incase of a successful WorkerLatencyProfile rollout.
* The Machine Config Operator generates events in case of any rollout failures. The "worker" machine config pool gets updated in case of a successful WorkerLatencyProfile rollout.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Addressed

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 10, 2022
@sairameshv
Copy link
Member Author

Hello @dhellmann , Would you mind adding the override comment once again?

Thanks

soltysh
soltysh approved these changes May 11, 2022
View reviewed changes
Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@soltysh
Copy link
Member

soltysh commented May 11, 2022

/override ci/prow/markdownlint

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 11, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 11, 2022

@soltysh: Overrode contexts on behalf of soltysh: ci/prow/markdownlint

In response to this:

/override ci/prow/markdownlint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 11, 2022

@sairameshv: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 11, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit d91cb37 into openshift:master May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@celebdor celebdor Awaiting requested review from celebdor

@mfojtik mfojtik Awaiting requested review from mfojtik

Assignees

@soltysh soltysh

@harche harche

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sairameshv @dhellmann @harche @soltysh @openshift-merge-robot