config/v1/types_cluster_version: Add architecture field #1219
Conversation
|
Hello @jottofar! Some important instructions when contributing to openshift/api: For merging purposes, this repository follows the no-Feature-Freeze process which means that in addition to the standard
OR
Who should apply these qe/docs/px labels?
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jottofar The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retitle WIP: config/v1/types_cluster_version: Add archiecture field |
openshift-ci
bot
changed the title
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
/retitle config/v1/types_cluster_version: Add architecture field |
openshift-ci
bot
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
config/v1/types_cluster_version.go
Outdated
| @@ -95,6 +95,13 @@ type ClusterVersionStatus struct { | |||
| // +required | |||
| Desired Release `json:"desired"` | |||
|
|
|||
| // architecture indicates whether the cluster is a homogeneous or | |||
There was a problem hiding this comment.
What transitions are allowed for this value?
There was a problem hiding this comment.
all transitions are theoretically allowed. multi -> amd64 and amd64 -> multi should be fairly straightforward. To do amd64 -> s390x, you'd need to do some fairly exciting dances, likely passing through multi in between.
There was a problem hiding this comment.
are we saying that if there is a transition from amd64->s390x, it will involve a middle stage of first moving to multi and then to the other single arch?
i'm wondering if single -> multi should be the only allowed transition.
|
/retest |
As described in [enhancement], add architecture fields to ClusterVersionSpec and to ClusterVersionStatus. The former indicates the desired architecture and the later indicates the current architecture. A cluster's architecture can be either homogeneous or heterogeneous. A single valid architecture value, e.g. "amd64", indicates an homogeneous cluster and "multi" indicates a heterogeneous cluster. [enhancement]: https://github.com/openshift/enhancements/blob/836516786ce47bf74a8a3dfe8a2fa7f1143e94c9/enhancements/multi-arch/heterogeneous-architecture-clusters.md
| // value of the cluster architecture. Setting this value will trigger | ||
| // an upgrade if the value does not match the current cluster | ||
| // architecture. | ||
| // +optional |
| // architecture identifies the architecture of the cluster nodes. If | ||
| // the cluster architecture is heterogeneous, whereby the cluster | ||
| // has nodes running on different architectures, "multi" is used. | ||
| // +optional |
There was a problem hiding this comment.
explain whether empty is a temporary condition or a long term condition to help consumers know what to expect.
|
Minor comments, then, lgtm. bug me on slack when updated. |
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
openshift-merge-robot
added
the
needs-rebase
|
@jottofar: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@jottofar: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/close |
|
@jottofar: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
As described in enhancement, add architecture fields to ClusterVersionSpec and to ClusterVersionStatus. The former indicates the desired architecture and the later indicates the current architecture. A cluster's architecture can be either homogeneous or heterogeneous. A single valid architecture value, e.g. "amd64", indicates an homogeneous cluster and "multi" indicates a heterogeneous cluster.