Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OCPNODE-521]Register ImageDigest/TagMirrorSet CRDs #1318

Merged
merged 1 commit into from Nov 3, 2022

Conversation

QiWang19
Copy link
Member

@QiWang19 QiWang19 commented Oct 1, 2022

Register ImageDigestMirrorset, ImageTagMirrorSet from 4.13.
These CRDs were unregistered before since we planned it for 4.13. Now, 4.13 branch is open, we can get this in.

CRD implementation: openshift/machine-config-operator#3037

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 1, 2022

Hello @QiWang19! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

For merging purposes, this repository follows the no-Feature-Freeze process which means that in addition to the standard lgtm and approved labels this repository requires either:

bugzilla/valid-bug - applied if your PR references a valid bugzilla bug

OR

qe-approved, docs-approved, and px-approved - these labels can be applied by anyone in the openshift org via the /label <labelname> command.

Who should apply these qe/docs/px labels?

  • For a no-Feature-Freeze team who is merging a feature before code freeze, they need to get those labels applied to their api repo PR by the appropriate teams (i.e. qe, docs, px)
  • For a Feature Freeze (traditional) team who is merging a feature before FF, they can self-apply the labels (via /label commands), they are basically irrelevant for those teams
  • For a Feature Freeze team who is merging a feature after FF, the PR should be rejected barring an exception

@QiWang19
Copy link
Member Author

QiWang19 commented Oct 1, 2022

/label px-approved
/label qe-approved
/label docs-approved

@openshift-ci openshift-ci bot added px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR docs-approved Signifies that Docs has signed off on this PR labels Oct 1, 2022
@QiWang19
Copy link
Member Author

QiWang19 commented Oct 1, 2022

/hold

4.13 tree to open

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 1, 2022
@QiWang19
Copy link
Member Author

/hold cancel
4.13 branch is open

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 21, 2022
@rphillips
Copy link
Contributor

/lgtm
/assign @JoelSpeed

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 1, 2022
@QiWang19
Copy link
Member Author

QiWang19 commented Nov 1, 2022

@deads2k Could you merge this? the CRDs was unregistered before #1296 since we planned it for 4.13

@JoelSpeed
Copy link
Contributor

/test all

@JoelSpeed
Copy link
Contributor

You need to add integration tests for these CRDs to pass, please checkout the repo, rebase on the latest changes and run ./tests/hack/gen-minimal-test.sh ./config/v1 v1 and it should generate a minimal test for both CRDs. Make sure these pass (make -C config/v1 test), and if they don't, that means you have required or defaulted fields, add these to the minimal tests as appropriate

  register ImageDigestMirrorset, ImageTagMirrorSet for 4.13.

Signed-off-by: Qi Wang <qiwan@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 2, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 2, 2022

@QiWang19: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@QiWang19
Copy link
Member Author

QiWang19 commented Nov 2, 2022

@JoelSpeed @rphillips PTAL

@JoelSpeed
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 3, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 3, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed, QiWang19, rphillips

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 3, 2022
@openshift-merge-robot openshift-merge-robot merged commit ea838af into openshift:master Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants