New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OCPNODE-521]Register ImageDigest/TagMirrorSet CRDs #1318
Conversation
Hello @QiWang19! Some important instructions when contributing to openshift/api: For merging purposes, this repository follows the no-Feature-Freeze process which means that in addition to the standard
OR
Who should apply these qe/docs/px labels?
|
/label px-approved |
/hold 4.13 tree to open |
/hold cancel |
/lgtm |
/test all |
You need to add integration tests for these CRDs to pass, please checkout the repo, rebase on the latest changes and run |
register ImageDigestMirrorset, ImageTagMirrorSet for 4.13. Signed-off-by: Qi Wang <qiwan@redhat.com>
cb07e00
to
27010b3
Compare
@QiWang19: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@JoelSpeed @rphillips PTAL |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed, QiWang19, rphillips The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Register ImageDigestMirrorset, ImageTagMirrorSet from 4.13.
These CRDs were unregistered before since we planned it for 4.13. Now, 4.13 branch is open, we can get this in.
CRD implementation: openshift/machine-config-operator#3037