[release-4.11] OCPBUGS-3560: operator/ingress: Allow PROXY protocol for Private endpoint publishing strategy #1344

openshift-cherrypick-robot · 2022-11-11T17:47:31Z

This is an automated cherry-pick of #1221

/assign Miciah

Allow configuring an IngressController with the "Private" endpoint publishing strategy type to use PROXY protocol. This commit fixes bug 2104481. https://bugzilla.redhat.com/show_bug.cgi?id=2104481 * operator/v1/types_ingress.go (PrivateStrategy): Add Protocol field with type IngressControllerProtocol. * operator/v1/0000_50_ingress-operator_00-ingresscontroller.crd.yaml: * operator/v1/zz_generated.swagger_doc_generated.go: Regenerate.

openshift-ci-robot · 2022-11-11T17:47:35Z

@openshift-cherrypick-robot: An error was encountered translating bugzilla components to jira components for bug 2104481 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message.


No mapping from bz component Networking with subcomponent router to a jira component found

Please contact an administrator to resolve this issue, then request a bug refresh with /jira refresh.

In response to this:

This is an automated cherry-pick of #1221

/assign Miciah

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2022-11-11T17:47:36Z

Hello @openshift-cherrypick-robot! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

For merging purposes, this repository follows the no-Feature-Freeze process which means that in addition to the standard lgtm and approved labels this repository requires either:

bugzilla/valid-bug - applied if your PR references a valid bugzilla bug

OR

qe-approved, docs-approved, and px-approved - these labels can be applied by anyone in the openshift org via the /label <labelname> command.

Who should apply these qe/docs/px labels?

For a no-Feature-Freeze team who is merging a feature before code freeze, they need to get those labels applied to their api repo PR by the appropriate teams (i.e. qe, docs, px)
For a Feature Freeze (traditional) team who is merging a feature before FF, they can self-apply the labels (via /label commands), they are basically irrelevant for those teams
For a Feature Freeze team who is merging a feature after FF, the PR should be rejected barring an exception

openshift-ci · 2022-11-11T17:47:41Z

@openshift-cherrypick-robot: An error was encountered cloning bug for cherrypick for bug 2104481 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message.


code 51: There is no component named 'ARRAY(0x55e02e8f7f10)' in the 'OpenShift Container Platform' product.

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

[release-4.11] Bug 2104481: operator/ingress: Allow PROXY protocol for Private endpoint publishing strategy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Miciah · 2022-11-11T17:48:05Z

/retitle [release-4.11] OCPBUGS-3559: operator/ingress: Allow PROXY protocol for Private endpoint publishing strategy

openshift-ci · 2022-11-11T17:48:35Z

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.11] OCPBUGS-3559: operator/ingress: Allow PROXY protocol for Private endpoint publishing strategy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2022-11-11T17:48:35Z

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-3559, which is invalid:

expected the bug to be open, but it isn't
expected the bug to target the "4.11.z" version, but it targets "4.12.0" instead
expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Closed (Done) instead
expected Jira Issue OCPBUGS-3559 to depend on a bug targeting a version in 4.12.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #1221

/assign Miciah

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Miciah · 2022-11-11T17:49:04Z

Oops.
/retitle [release-4.11] OCPBUGS-3560: operator/ingress: Allow PROXY protocol for Private endpoint publishing strategy

openshift-ci-robot · 2022-11-11T17:49:11Z

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-3560, which is invalid:

expected Jira Issue OCPBUGS-3560 to depend on a bug targeting a version in 4.12.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #1221

/assign Miciah

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2022-11-11T17:49:11Z

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.11] OCPBUGS-3560: operator/ingress: Allow PROXY protocol for Private endpoint publishing strategy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Miciah · 2022-11-11T17:49:55Z

/jira refresh

openshift-ci-robot · 2022-11-11T17:50:02Z

@Miciah: This pull request references Jira Issue OCPBUGS-3560, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.11.z) matches configured target version for branch (4.11.z)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
dependent bug Jira Issue OCPBUGS-3559 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
dependent Jira Issue OCPBUGS-3559 targets the "4.12.0" version, which is one of the valid target versions: 4.12.0
bug has dependents

Requesting review from QA contact:
/cc @lihongan

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2022-11-11T17:59:47Z

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

candita · 2022-11-23T20:26:24Z

/assign @rfredette

rfredette · 2022-11-28T15:58:23Z

/lgtm

Miciah · 2023-01-12T00:18:32Z

/jira refresh

openshift-ci-robot · 2023-01-12T00:18:35Z

@Miciah: This pull request references Jira Issue OCPBUGS-3560, which is valid.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.11.z) matches configured target version for branch (4.11.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
dependent bug Jira Issue OCPBUGS-3559 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
dependent Jira Issue OCPBUGS-3559 targets the "4.12.0" version, which is one of the valid target versions: 4.12.0
bug has dependents

Requesting review from QA contact:
/cc @ShudiLi

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ShudiLi · 2023-01-12T01:43:43Z

/label qe-approved

JoelSpeed · 2023-01-12T09:24:39Z

/approve

deads2k · 2023-01-25T15:39:35Z

/approve

wangke19 · 2023-01-29T02:52:11Z

/label cherry-pick-approved

soltysh

/label backport-risk-assessed

openshift-ci · 2023-04-26T10:23:30Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, JoelSpeed, openshift-cherrypick-robot, rfredette, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [deads2k,soltysh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2023-04-26T10:27:07Z

@openshift-cherrypick-robot: Jira Issue OCPBUGS-3560: All pull requests linked via external trackers have merged:

openshift/api#1344

Jira Issue OCPBUGS-3560 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #1221

/assign Miciah

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-merge-robot · 2023-05-04T14:16:12Z

Fix included in accepted release 4.11.0-0.nightly-2023-05-04-100517

openshift-cherrypick-robot mentioned this pull request Nov 11, 2022

Bug 2104481: operator/ingress: Allow PROXY protocol for Private endpoint publishing strategy #1221

Merged

openshift-ci bot assigned Miciah Nov 11, 2022

openshift-ci bot changed the title ~~[release-4.11] Bug 2104481: operator/ingress: Allow PROXY protocol for Private endpoint publishing strategy~~ [release-4.11] OCPBUGS-3559: operator/ingress: Allow PROXY protocol for Private endpoint publishing strategy Nov 11, 2022

openshift-ci-robot added the jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. label Nov 11, 2022

openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Nov 11, 2022

openshift-ci bot requested review from bparees and jwforres November 11, 2022 17:48

openshift-ci bot changed the title ~~[release-4.11] OCPBUGS-3559: operator/ingress: Allow PROXY protocol for Private endpoint publishing strategy~~ [release-4.11] OCPBUGS-3560: operator/ingress: Allow PROXY protocol for Private endpoint publishing strategy Nov 11, 2022

openshift-ci bot requested a review from lihongan November 11, 2022 17:50

openshift-ci bot assigned rfredette Nov 23, 2022

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 28, 2022

openshift-ci bot requested a review from ShudiLi January 12, 2023 00:18

openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Jan 12, 2023

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 25, 2023

openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jan 29, 2023

soltysh approved these changes Apr 26, 2023

View reviewed changes

openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Apr 26, 2023

openshift-ci bot assigned gangwgr, wangke19 and xingxingxia Apr 26, 2023

openshift-merge-robot merged commit 398424d into openshift:release-4.11 Apr 26, 2023
1 check passed

openshift-ci-robot mentioned this pull request May 4, 2023

[release-4.11] OCPBUGS-3560: Allow PROXY protocol for "Private" strategy openshift/cluster-ingress-operator#914

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[release-4.11] OCPBUGS-3560: operator/ingress: Allow PROXY protocol for Private endpoint publishing strategy #1344

[release-4.11] OCPBUGS-3560: operator/ingress: Allow PROXY protocol for Private endpoint publishing strategy #1344

openshift-cherrypick-robot commented Nov 11, 2022

openshift-ci-robot commented Nov 11, 2022

openshift-ci bot commented Nov 11, 2022

openshift-ci bot commented Nov 11, 2022

Miciah commented Nov 11, 2022

openshift-ci bot commented Nov 11, 2022

openshift-ci-robot commented Nov 11, 2022

Miciah commented Nov 11, 2022

openshift-ci-robot commented Nov 11, 2022

openshift-ci bot commented Nov 11, 2022

Miciah commented Nov 11, 2022

openshift-ci-robot commented Nov 11, 2022

openshift-ci bot commented Nov 11, 2022

candita commented Nov 23, 2022

rfredette commented Nov 28, 2022

Miciah commented Jan 12, 2023

openshift-ci-robot commented Jan 12, 2023

ShudiLi commented Jan 12, 2023

JoelSpeed commented Jan 12, 2023

deads2k commented Jan 25, 2023

wangke19 commented Jan 29, 2023

soltysh left a comment

openshift-ci bot commented Apr 26, 2023

openshift-ci-robot commented Apr 26, 2023

openshift-merge-robot commented May 4, 2023

[release-4.11] OCPBUGS-3560: operator/ingress: Allow PROXY protocol for Private endpoint publishing strategy #1344

[release-4.11] OCPBUGS-3560: operator/ingress: Allow PROXY protocol for Private endpoint publishing strategy #1344

Conversation

openshift-cherrypick-robot commented Nov 11, 2022

openshift-ci-robot commented Nov 11, 2022

openshift-ci bot commented Nov 11, 2022

openshift-ci bot commented Nov 11, 2022

Miciah commented Nov 11, 2022

openshift-ci bot commented Nov 11, 2022

openshift-ci-robot commented Nov 11, 2022

Miciah commented Nov 11, 2022

openshift-ci-robot commented Nov 11, 2022

openshift-ci bot commented Nov 11, 2022

Miciah commented Nov 11, 2022

openshift-ci-robot commented Nov 11, 2022

openshift-ci bot commented Nov 11, 2022

candita commented Nov 23, 2022

rfredette commented Nov 28, 2022

Miciah commented Jan 12, 2023

openshift-ci-robot commented Jan 12, 2023

ShudiLi commented Jan 12, 2023

JoelSpeed commented Jan 12, 2023

deads2k commented Jan 25, 2023

wangke19 commented Jan 29, 2023

soltysh left a comment

Choose a reason for hiding this comment

openshift-ci bot commented Apr 26, 2023

openshift-ci-robot commented Apr 26, 2023

openshift-merge-robot commented May 4, 2023