(PSAP-741) config/v1/types_cluster_version: add node-tuning capability

[dagrayvid]

Along with adding a 4.13 capability set, this PR adds node-tuning to the set of OpenShift capabilities that can be optionally disabled at cluster install starting with OpenShift 4.13. This can be used to disable the Node Tuning Operator (NTO) and the containerized TuneD daemon which it manages.

The Node Tuning Operator applies TuneD default profiles to the control plane and worker nodes, and enables users to apply custom OS-level tuning. When disabled, the default tuning profiles will not be applied which may impact the performance of certain workloads, and will impact scalability of very large clusters (~900 nodes or ~1000 routes).

Any tuning that is functionally required will be handled by MCO going forward (see openshift/machine-config-operator#3440)

Related to PSAP-741. This must be merged before openshift/cluster-node-tuning-operator#524

[openshift-ci]

Hello @dagrayvid! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

For merging purposes, this repository follows the no-Feature-Freeze process which means that in addition to the standard lgtm and approved labels this repository requires either:

bugzilla/valid-bug - applied if your PR references a valid bugzilla bug

OR

qe-approved, docs-approved, and px-approved - these labels can be applied by anyone in the openshift org via the /label <labelname> command.

Who should apply these qe/docs/px labels?

• For a no-Feature-Freeze team who is merging a feature before code freeze, they need to get those labels applied to their api repo PR by the appropriate teams (i.e. qe, docs, px)
• For a Feature Freeze (traditional) team who is merging a feature before FF, they can self-apply the labels (via /label commands), they are basically irrelevant for those teams
• For a Feature Freeze team who is merging a feature after FF, the PR should be rejected barring an exception

[dagrayvid]

/cc @bparees
Also, should we add a ClusterVersionCapabilitySet4_13?

[bparees]

Also, should we add a ClusterVersionCapabilitySet4_13?

yes

[dagrayvid]

Thanks @bparees , I switched to the preferred capitalization of NodeTuning, and added a ClusterVersionCapabilitySet4_13

[dagrayvid]

I split the PR into two commits, one for the 4.13 capability set, one for adding the NodeTuning capability.

[dagrayvid]

@bparees I think this PR is ready for further review / merge

[bparees]

looks right to me, but you'll need someone from @openshift/api-reviewers to sign off

[liqcui]

/label qe-approved

[sheriff-rh]

/label docs-approved

[deads2k]

This looks ok to me as long as the feature owner agrees and thinks it's plausible.

@jmencak You're the node tuning owner? Can I get your lgtm on this PR?

/approve
/hold

holding for @jmencak's lgtm

[jmencak]

Thank you David and David.
/hold cancel
/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dagrayvid, deads2k, jmencak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [deads2k]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[dagrayvid]

/cc @control-d
Can you please give the px-approved label needed for merge?

[control-d]

/label px-approved

[openshift-ci]

@dagrayvid: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.