Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CFE-685 : Add TechPreviewNoUpgrade featureGate for GCP Labels and Tags support #1474

Merged
merged 1 commit into from
May 30, 2023

Conversation

bharath-b-rh
Copy link
Contributor

Support for adding labels and tags to GCP resources created for OCP cluster through enhancement will be made available as TechPreview in OpenShift-4.14 and the PR contains GCPLabelsTags featureGate added for the same.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 30, 2023

Hello @bharath-b-rh! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 30, 2023
@openshift-ci openshift-ci bot requested review from bparees and JoelSpeed May 30, 2023 05:10
@bharath-b-rh
Copy link
Contributor Author

/cc @JoelSpeed

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 30, 2023

@bharath-b-rh: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JoelSpeed
Copy link
Contributor

/lgtm

You'll need a PR to cluster-config-operator to activate this within the cluster. Then components adding functionality for this feature gate should be updated to only activate the new code when the feature gate is enabled.

This FAQ may be helpful.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 30, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bharath-b-rh, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 30, 2023
@openshift-merge-robot openshift-merge-robot merged commit 1d902c5 into openshift:master May 30, 2023
7 checks passed
@bharath-b-rh bharath-b-rh deleted the cfe-685-fg branch May 30, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants