Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

restrict network migration mode to techpreview #1560

Closed
wants to merge 7 commits into from
Closed

restrict network migration mode to techpreview #1560

wants to merge 7 commits into from

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Aug 16, 2023

#1546 with gating on the API field.

/assign @pliurh

pliurh and others added 4 commits August 13, 2023 23:28
@pliurh
Add new flag to Networks.operator.openshift.io for SDN live migration
679f621 
Add flag 'mode' to 'spec.Migration' to indicate SDN migration mode.
The supported values are Live, Offline. If unset, the default mode is
Offline.

Signed-off-by: Peng Liu <pliu@redhat.com>
@pliurh
Add TechPreview feature gate for SDN live migration
2ac22e1 
This commit adds a feature gate for SDN live Migration feature.

Signed-off-by: Peng Liu <pliu@redhat.com>
@deads2k
stub files for techpreview CRD schema
5ff83a8
@deads2k
restrict network migration mode to techpreview
4cfed61
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 16, 2023

Hello @deads2k! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 16, 2023
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 16, 2023
@pliurh
Copy link
Contributor

pliurh commented Aug 16, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 16, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, pliurh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD a2362cf and 2 for PR HEAD 0ebf03f in total

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 16, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 16, 2023

New changes are detected. LGTM label has been removed.

@pliurh
Copy link
Contributor

pliurh commented Aug 17, 2023

/retest

JoelSpeed
JoelSpeed reviewed Aug 17, 2023
View reviewed changes
operator/v1/0000_70_cluster-network-operator_01-Default.crd.yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renaming this file has broken the integration tests, need to update the integration test to point to the new file name

JoelSpeed
JoelSpeed reviewed Aug 23, 2023
View reviewed changes
operator/v1/custom.network.testsuite.yaml
@@ -0,0 +1,21 @@
apiVersion: apiextensions.k8s.io/v1 # Hack because controller-gen complains if we don't have this
name: "[Stable] Network"
crd: 0000_70_cluster-network-operator_01-Custom.crd.yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
crd: 0000_70_cluster-network-operator_01-Custom.crd.yaml
crd: 0000_70_cluster-network-operator_01-CustomNoUpgrade.crd.yaml

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 25, 2023
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 31, 2023

@deads2k: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/integration 8bd47b2 link true /test integration
ci/prow/verify-crd-schema 8bd47b2 link true /test verify-crd-schema

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pliurh
Copy link
Contributor

pliurh commented Sep 8, 2023

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 8, 2023
@deads2k deads2k closed this Oct 18, 2023
@kyrtapz kyrtapz mentioned this pull request Oct 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoelSpeed JoelSpeed JoelSpeed left review comments

@bparees bparees Awaiting requested review from bparees

@sjenning sjenning Awaiting requested review from sjenning

Assignees

@pliurh pliurh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@deads2k @pliurh @openshift-ci-robot @openshift-merge-robot @JoelSpeed