OCPBUGS-17851: AzureMachineProviderSpec convert zone to non-pointer

[RadekManak]

This PR removes pointer from the zone field in AzureMachineProviderSpec to simplify conversion between it and CPMS's Azure failure domain that already uses a non-pointer Zone.
This change will be a no-op in terms of the data stored in etcd since the type is unstructured anyway. I'll update all the users of this API. (MAPZ, installer, cluster-api-actuator-pkg, CPMSO)

[openshift-ci-robot]

@RadekManak: This pull request references Jira Issue OCPBUGS-17851, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.14.0) matches configured target version for branch (4.14.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sunzhaohua2

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This PR removes pointer from the zone field in AzureMachineProviderSpec to simplify conversion between it and CPMS's Azure failure domain that already uses a non-pointer Zone.
This change will be a no-op in terms of the data stored in etcd since the type is unstructured anyway. I'll update all the users of this API. (MAPZ, installer, CPMSO)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

Hello @RadekManak! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[openshift-ci-robot]

@RadekManak: This pull request references Jira Issue OCPBUGS-17851, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.14.0) matches configured target version for branch (4.14.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sunzhaohua2

In response to this:

This PR removes pointer from the zone field in AzureMachineProviderSpec to simplify conversion between it and CPMS's Azure failure domain that already uses a non-pointer Zone.
This change will be a no-op in terms of the data stored in etcd since the type is unstructured anyway. I'll update all the users of this API. (MAPZ, installer, cluster-api-actuator-pkg, CPMSO)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[JoelSpeed]

The only place that this field is read, we do a pointer dereference and then return "" if the pointer is nil, so this will be a no-op change in terms of consumption and this moves towards the convention of having only a single way to express a configuration that is desired. Other uses of this field only set the field for consumption in CAPZ, so again, no effective difference to behaviour for this change.
https://github.com/openshift/machine-api-provider-azure/blob/458e10c9b4f57f1c26613da7e0c2b5feb7118921/pkg/cloud/azure/actuators/machine/reconciler.go#L549-L551
/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed, RadekManak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [JoelSpeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@RadekManak: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci-robot]

@RadekManak: Jira Issue OCPBUGS-17851: All pull requests linked via external trackers have merged:

• openshift/api#1565

Jira Issue OCPBUGS-17851 has been moved to the MODIFIED state.

In response to this:

This PR removes pointer from the zone field in AzureMachineProviderSpec to simplify conversion between it and CPMS's Azure failure domain that already uses a non-pointer Zone.
This change will be a no-op in terms of the data stored in etcd since the type is unstructured anyway. I'll update all the users of this API. (MAPZ, installer, cluster-api-actuator-pkg, CPMSO)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.