New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
have the CVO manage CRDs from the api image #1666
Conversation
Hello @deads2k! Some important instructions when contributing to openshift/api: |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@deads2k: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
launch openshift/cluster-config-operator#379,#1666 worked |
openshift/installer#7666 switching the installer rendering to use openshift/api has tested green and is ready to make the switch #1666 and openshift/cluster-config-operator#379 have clusterbot tested together fine. They hand off the CVO management of CRDs (and others) from cluster-config-operator to api image. openshift/cluster-config-operator#349 switches the featuregate setting from using the vendored copy from to using openshift/api. It tested green until it openshift/api updated without a (yet) merged openshift/cluster-config-operator update, so the machine-config-operator mismatched until they rematch. But in combination with the rendering change linked above they will match ok. Manually merging to get a batch. |
[ART PR BUILD NOTIFIER] This PR has been included in build ose-cluster-config-api-container-v4.15.0-202311291533.p0.ga782d1c.assembly.stream for distgit ose-cluster-config-api. |
Full chain is
/hold
must merge together with openshift/cluster-config-operator#379
While the vendored level in cluster-config-operator matches, these can show green simultaneously. When that happens, we need to manually merge both to avoid future conflicts.