Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CNF-10474:feature-gate: add mixedCPUs to feature gate #1684

Merged
merged 1 commit into from Nov 28, 2023
Merged

CNF-10474:feature-gate: add mixedCPUs to feature gate #1684

merged 1 commit into from Nov 28, 2023

Conversation

Tal-or
Copy link
Contributor

@Tal-or Tal-or commented Nov 27, 2023

Adding a feature gate to mixedCPUs feature.
The full enhancement proposal can be found here: openshift/enhancements@76ea48a

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 27, 2023

Hello @Tal-or! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 27, 2023
mrunalp
mrunalp reviewed Nov 27, 2023
View reviewed changes
config/v1/feature_gates.go Outdated Show resolved Hide resolved
mrunalp
mrunalp reviewed Nov 27, 2023
View reviewed changes
config/v1/feature_gates.go Outdated Show resolved Hide resolved
@mrunalp
Copy link
Member

mrunalp commented Nov 27, 2023

/lgtm

@mrunalp
Copy link
Member

mrunalp commented Nov 27, 2023

@deads2k @JoelSpeed ptal

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 27, 2023
@deads2k
Copy link
Contributor

deads2k commented Nov 27, 2023

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 27, 2023
@mrunalp
Copy link
Member

mrunalp commented Nov 28, 2023

/test e2e-aws-serial-techpreview

1 similar comment
@Tal-or
Copy link
Contributor Author

Tal-or commented Nov 28, 2023

/test e2e-aws-serial-techpreview

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD d83ab5b and 2 for PR HEAD 5a9c68a in total

@Tal-or
Copy link
Contributor Author

Tal-or commented Nov 28, 2023

/test e2e-aws-serial-techpreview

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD e1845c5 and 1 for PR HEAD 5a9c68a in total

@Tal-or Tal-or mentioned this pull request Nov 28, 2023
Merged
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 436a23f and 0 for PR HEAD 5a9c68a in total

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 28, 2023
@Tal-or
feature-gate: add mixedCPUs to feature gate
4cd5eda 
Signed-off-by: Talor Itzhak <titzhak@redhat.com>
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 28, 2023
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 28, 2023
@Tal-or
Copy link
Contributor Author

Tal-or commented Nov 28, 2023

PR needed a rebase hence re-pushed

@Tal-or Tal-or changed the title feature-gate: add mixedCPUs to feature gate CNF-10474:feature-gate: add mixedCPUs to feature gate Nov 28, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 28, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 28, 2023 •
edited by openshift-ci bot

@Tal-or: This pull request references CNF-10474 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to this:

Adding a feature gate to mixedCPUs feature.
The full enhancement proposal can be found here: openshift/enhancements@76ea48a

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mrunalp
Copy link
Member

mrunalp commented Nov 28, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 28, 2023
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, mrunalp, Tal-or

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 436a23f and 2 for PR HEAD 4cd5eda in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 28, 2023

@Tal-or: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 03f577b into openshift:master Nov 28, 2023
16 checks passed
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-config-api-container-v4.15.0-202311290051.p0.g03f577b.assembly.stream for distgit ose-cluster-config-api.
All builds following this will include this PR.

@Tal-or Tal-or deleted the add_mixed_cpus_feature_gate branch November 29, 2023 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrunalp mrunalp mrunalp left review comments

@bparees bparees Awaiting requested review from bparees

@deads2k deads2k Awaiting requested review from deads2k

Assignees

@mrunalp mrunalp

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Tal-or @mrunalp @deads2k @openshift-ci-robot @openshift-bot @openshift-merge-robot