[release-4.15] CORS-3029: Add Cloud LB IPs to GCP PlatformStatus of Infrastructure CR #1705
Conversation
1. Make CloudLoadBalancerConfig an union with the dnsType as a discriminator 2. Add API, API-Int and Ingress LB IPs to Infrastructure CR's GCP PlatformStatus 3. Add IP type
|
@openshift-cherrypick-robot: An error was encountered cloning bug for cherrypick for bug CORS-3029 on the Jira server at https://issues.redhat.com/. No known errors were detected, please see the full error message for details. Full error message.
request failed. Please analyze the request body for more details. Status code: 400: {"errorMessages":["Number value expected as the Sprint id."],"errors":{"customfield_12318341":"Operation value must be a string"}}
Please contact an administrator to resolve this issue, then request a bug refresh with In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Hello @openshift-cherrypick-robot! Some important instructions when contributing to openshift/api: |
openshift-ci
bot
added
the
size/XL
|
/hold @sadasu Can you please get the code implemented, merged, and verified for the 4.16 branch and then open placeholder backports for the changes. Once we have everything lined up, lets come back to this and get it merged, and then get the other code changes merged in quick succession |
openshift-ci
bot
added
the
do-not-merge/hold
|
/retest-required |
|
@JoelSpeed openshift/installer#7837 are the minimal Installer changes required to incorporate CloudLoadBalancerConfig in place of ClusterHostedDNS. And, it has merged. openshift/installer#7838 is the 4.15 backport of the same changes. |
|
/test e2e-azure |
|
/lgtm |
openshift-ci
bot
added
backport-risk-assessed
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/verify-crd-schema In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@openshift-cherrypick-robot: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/label cherry-pick-approved |
|
@yunjiang29: Can not set label cherry-pick-approved: Must be member in one of these teams: [openshift-staff-engineers] In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@jianlinliu, this PR needs your |
|
/label cherry-pick-approved |
|
@jianlinliu: Can not set label cherry-pick-approved: Must be member in one of these teams: [openshift-staff-engineers] In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/label cherry-pick-approved |
openshift-ci
bot
added
the
cherry-pick-approved
sdodson
added
the
jira/valid-bug
openshift-merge-bot
bot
merged commit e4433f7
into
openshift:release-4.15
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-cluster-config-api-container-v4.15.0-202401051551.p0.ge4433f7.assembly.stream for distgit ose-cluster-config-api. |
This is an automated cherry-pick of #1685
/assign JoelSpeed