-
Notifications
You must be signed in to change notification settings - Fork 584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
To Install helmcharts through Samples operator #1754
To Install helmcharts through Samples operator #1754
Conversation
Signed-off-by: Feny Mehta <fbm3307@gmail.com>
Hello @fbm3307! Some important instructions when contributing to openshift/api: |
Signed-off-by: Feny Mehta <fbm3307@gmail.com>
Signed-off-by: Feny Mehta <fbm3307@gmail.com>
@fbm3307 Test suite is in https://github.com/openshift/api/blob/master/samples/v1/stable.config.testsuite.yaml, you should be able to add cases where the values are accepted, in which case there's already an example. And for cases that are not accepted, instead of Test cases I think we should have
|
Signed-off-by: Feny Mehta <fbm3307@gmail.com>
Signed-off-by: Feny Mehta <fbm3307@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of bits to fix in the tests otherwise LGTM
@fbm3307: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/label tide/merge-method-squash |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dperaza4dustbit, fbm3307, JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[ART PR BUILD NOTIFIER] This PR has been included in build ose-cluster-config-api-container-v4.16.0-202402091340.p0.g113e7e4.assembly.stream.el9 for distgit ose-cluster-config-api. |
This PR is to update the Cluster Samples Operator CRD to have the Helmchart List . This is Part of Samples operator Downsizing Phase-2, where the S2i Sample helmcharts can be installed via CSO.
Refernce -SO-112