MCO-993: MachineOSBuild API #1773
Conversation
|
Skipping CI for Draft Pull Request. |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Hello @cdoern! Some important instructions when contributing to openshift/api: |
openshift-ci
bot
added
the
size/XXL
cdoern
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@cdoern: This pull request references MCO-993 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@cdoern: This pull request references MCO-993 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
cdoern
force-pushed
the
build
branch
2 times, most recently
from
a5708c3
to
beb81e8
Compare
cdoern
changed the title
|
@cdoern: This pull request references MCO-993 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
size/XL
cdoern
force-pushed
the
build
branch
4 times, most recently
from
102ced6
to
86124de
Compare
openshift-ci
bot
removed
the
size/XL
|
/approve |
openshift-ci
bot
added
the
approved
| // describes the x86_64 architecture | ||
| X86_64 ContainerFileArch = "x86_64" | ||
| // describes a containerfile that can be applied to any arch | ||
| NoArch ContainerFileArch = "noArch" |
There was a problem hiding this comment.
suggestion: For consistency, the value for NoArch should probably be noarch since that's the convention that dnf / yum use for packages which work on all architectures.
|
/lgtm |
|
@cdoern: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
machineOSBuild and Image are meant to represent the two components of an on cluster build, making this commit the user-facing API for on cluster builds. MOSBuilds comprise of the actual processes of kicking off an monitoring a build. A MachineOSConfig contains user options like the push/pull spec for registries as well as the custom content in a dockerfile. a MOSImage is the result of a build. the Image objects are intended to be trackable and easily related to an MCP. The goal here is to remove much of the split state reporting for on cluster builds and consolidate where the user sets config options. Signed-off-by: Charlie Doern <cdoern@redhat.com>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cdoern, cheesesashimi, deads2k The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-cluster-config-api-container-v4.16.0-202404052115.p0.gabd990c.assembly.stream.el9 for distgit ose-cluster-config-api. |
machineOSBuild and Image are meant to represent the two components of an on cluster build, making this commit the user-facing API for on cluster builds.
MachineOSBuilds comprise of the actual processes of kicking off an monitoring a build. A build also contains user options like the push/pull spec for registries as well as the custom content in a containerfile. The state of a build will be tracked in here as well, and users will be able to view this in printer columns. A build is either: "Ready", "BuildPrepared", "Building", "BuildFailed", "BuildInterrupted", or "BuildRestarted"
As of 4.16, the MCO will migrate the currently implemented OCB functionality to this API. We are not looking to add new functionality in 4.16. However, in 4.17 specific elements of this API will most likely be pre-populated by work in the MCO. Where we can, we are looking to provide the user with all of the base image pull secrets, and final image push and pull secrets. For now, these must be user provided.