Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove ungated case from manifest-merge #1784

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Mar 6, 2024

Removes overrides for nearly all clusterprofiles (authentication remains because it needs featuregates-by-cluster-profile to work).

Removes overrides for ungated.

Removes ungated option from generator

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 6, 2024
Copy link
Contributor

openshift-ci bot commented Mar 6, 2024

Hello @deads2k! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 6, 2024
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 6, 2024
@deads2k deads2k force-pushed the by-gate-03-handle-ungated-in-merge branch from ca8d7e8 to a08f8f2 Compare March 8, 2024 18:30
@deads2k deads2k changed the title [wip] remove ungated case from manifest-merge remove ungated case from manifest-merge Mar 8, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 8, 2024
@deads2k deads2k force-pushed the by-gate-03-handle-ungated-in-merge branch from a08f8f2 to b940d09 Compare March 8, 2024 19:30
@deads2k
Copy link
Contributor Author

deads2k commented Mar 8, 2024

/override ci/prow/verify-crd-schema

Copy link
Contributor

openshift-ci bot commented Mar 8, 2024

@deads2k: Overrode contexts on behalf of deads2k: ci/prow/verify-crd-schema

In response to this:

/override ci/prow/verify-crd-schema

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@deads2k
Copy link
Contributor Author

deads2k commented Mar 9, 2024

/retest

1 similar comment
@deads2k
Copy link
Contributor Author

deads2k commented Mar 11, 2024

/retest

@JoelSpeed
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 11, 2024
Copy link
Contributor

openshift-ci bot commented Mar 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit dcd6ab3 into openshift:master Mar 11, 2024
16 of 17 checks passed
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-config-api-container-v4.16.0-202403111814.p0.gdcd6ab3.assembly.stream.el9 for distgit ose-cluster-config-api.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants