Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updating config stragglers to by-feature-gate generation #1793

Merged
merged 5 commits into from Mar 12, 2024
Merged

updating config stragglers to by-feature-gate generation #1793

merged 5 commits into from Mar 12, 2024

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Mar 11, 2024

/assign @JoelSpeed

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 11, 2024

Hello @deads2k! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 11, 2024
@openshift-ci openshift-ci bot requested review from bparees and soltysh March 11, 2024 19:31
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 11, 2024
@deads2k
Copy link
Contributor Author

deads2k commented Mar 11, 2024

/hold

hold to prioritize #1788

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 11, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 12, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 12, 2024
@deads2k
Copy link
Contributor Author

deads2k commented Mar 12, 2024

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 12, 2024
@deads2k
Copy link
Contributor Author

deads2k commented Mar 12, 2024

So strange that the verify doesn't reproduce locally. I wonder if something in my env is stale

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 12, 2024
JoelSpeed
JoelSpeed reviewed Mar 12, 2024
View reviewed changes
...ha1/zz_generated.featuregated-crd-manifests/insights.config.openshift.io/InsightsConfig.yaml Outdated
Comment on lines 12 to 15
kind: InsightsDataGather
listKind: InsightsDataGatherList
plural: insights
singular: insightsdatagather
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 of these 4 look wrong

JoelSpeed
JoelSpeed reviewed Mar 12, 2024
View reviewed changes
...ha1/zz_generated.featuregated-crd-manifests/insights.config.openshift.io/InsightsConfig.yaml Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this file should exist

@deads2k
Copy link
Contributor Author

deads2k commented Mar 12, 2024

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 12, 2024
@deads2k
Copy link
Contributor Author

deads2k commented Mar 12, 2024

/override ci/prow/verify-crd-schema

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 12, 2024

@deads2k: Overrode contexts on behalf of deads2k: ci/prow/verify-crd-schema

In response to this:

/override ci/prow/verify-crd-schema

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@deads2k deads2k added the lgtm Indicates that a PR is ready to be merged. label Mar 12, 2024
@deads2k
Copy link
Contributor Author

deads2k commented Mar 12, 2024

/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD b13710e and 2 for PR HEAD ae04696 in total

@deads2k
Copy link
Contributor Author

deads2k commented Mar 12, 2024

/override ci/prow/verify-crd-schema

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 12, 2024

@deads2k: Overrode contexts on behalf of deads2k: ci/prow/verify-crd-schema

In response to this:

/override ci/prow/verify-crd-schema

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 12, 2024

@deads2k: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 4785ede into openshift:master Mar 12, 2024
17 checks passed
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-config-api-container-v4.16.0-202403130014.p0.g4785ede.assembly.stream.el9 for distgit ose-cluster-config-api.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoelSpeed JoelSpeed JoelSpeed left review comments

@bparees bparees Awaiting requested review from bparees

@soltysh soltysh Awaiting requested review from soltysh

Assignees

@JoelSpeed JoelSpeed

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@deads2k @openshift-ci-robot @openshift-bot @JoelSpeed @openshift-merge-robot