Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move to new directory #1803

Merged
merged 5 commits into from Mar 15, 2024
Merged

move to new directory #1803

merged 5 commits into from Mar 15, 2024

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Mar 12, 2024

making draft to see if file move detection is helpful

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 12, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 12, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 12, 2024

Hello @deads2k! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 12, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 13, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 14, 2024
@deads2k deads2k marked this pull request as ready for review March 14, 2024 17:39
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 14, 2024
@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 14, 2024
@deads2k deads2k added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Mar 14, 2024
@deads2k
Copy link
Contributor Author

deads2k commented Mar 14, 2024

first I've benefited from the, "don't change the image, skip the e2es". Nice.

@JoelSpeed
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 15, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 21d8ea8 into openshift:master Mar 15, 2024
9 checks passed
alebedev87 added a commit to alebedev87/cluster-ingress-operator that referenced this pull request Apr 15, 2024
@alebedev87
manifests: get CRDs from new OpenShift API packages
49443b7 
IngressController and DNSRecord CRDs were moved to dedicated packages
following the introduction of a new method for generating CRDs in the OpenShift API (openshift/api#1803).
This commit adds these new packages as tool imports to make use of the go.mod versioning
and to be able to "go get" them before copying into manifests.
alebedev87 added a commit to alebedev87/cluster-ingress-operator that referenced this pull request Apr 16, 2024
@alebedev87
manifests: get CRDs from new OpenShift API packages
f38c147 
IngressController and DNSRecord CRDs were moved to dedicated packages
following the introduction of a new method for generating CRDs in the OpenShift API (openshift/api#1803).
This commit adds these new packages as tool imports to make use of the go.mod versioning
and to be able to "go get" them before copying into manifests.
@alebedev87 alebedev87 mentioned this pull request Apr 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bparees bparees Awaiting requested review from bparees

@cgwalters cgwalters Awaiting requested review from cgwalters

Assignees

@JoelSpeed JoelSpeed

Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@deads2k @JoelSpeed @openshift-merge-robot