Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make featuregate manifest pattern consistent and remove legacy files #1805

Merged

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Mar 13, 2024

Definitely need to be sure hypershift passes here. A quick scan suggests they're using injection (so we need to update their clusterProfile), but they're ok otherwise.

EDIT: actually, they're doing that here: https://github.com/openshift/hypershift/blob/main/control-plane-operator/controllers/hostedcontrolplane/kas/deployment.go#L791

I think this will "just work"

Copy link
Contributor

openshift-ci bot commented Mar 13, 2024

Hello @deads2k! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 13, 2024
Copy link
Contributor

openshift-ci bot commented Mar 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 13, 2024
@JoelSpeed
Copy link
Contributor

This is causing hack/verify-payload-featuregates.sh to fail

@openshift-ci openshift-ci bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 13, 2024
@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 13, 2024
@deads2k
Copy link
Contributor Author

deads2k commented Mar 13, 2024

/retest

@deads2k deads2k added the lgtm Indicates that a PR is ready to be merged. label Mar 13, 2024
@deads2k
Copy link
Contributor Author

deads2k commented Mar 13, 2024

labelling cleanup

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD bcf33ad and 2 for PR HEAD 676fb69 in total

Copy link
Contributor

openshift-ci bot commented Mar 14, 2024

@deads2k: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 4caef7f into openshift:master Mar 14, 2024
17 checks passed
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-config-api-container-v4.16.0-202403141746.p0.g4caef7f.assembly.stream.el9 for distgit ose-cluster-config-api.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants