New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make featuregate manifest pattern consistent and remove legacy files #1805
make featuregate manifest pattern consistent and remove legacy files #1805
Conversation
Hello @deads2k! Some important instructions when contributing to openshift/api: |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is causing |
b9b6dff
to
4fd86ee
Compare
3c1e73f
to
676fb69
Compare
/retest |
labelling cleanup |
@deads2k: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
[ART PR BUILD NOTIFIER] This PR has been included in build ose-cluster-config-api-container-v4.16.0-202403141746.p0.g4caef7f.assembly.stream.el9 for distgit ose-cluster-config-api. |
Definitely need to be sure hypershift passes here. A quick scan suggests they're using injection (so we need to update their clusterProfile), but they're ok otherwise.
EDIT: actually, they're doing that here: https://github.com/openshift/hypershift/blob/main/control-plane-operator/controllers/hostedcontrolplane/kas/deployment.go#L791
I think this will "just work"