explain roughly what the new generator is doing #1816
Conversation
|
Hello @deads2k! Some important instructions when contributing to openshift/api: |
openshift-ci
bot
added
the
size/M
openshift-ci
bot
added
the
approved
README.md
Outdated
| The most common kube-builder tags are re-implemented in this stage to fill in the non-schema portion of the CRD manifests. | ||
| This includes things like metadata, resource, and some custom openshift tags as well. | ||
|
|
||
| The generator ignores the schema when doing verify, so it doesn't fail on needing to run `schemagen`. |
| It has no knowledge of whether the FeatureGate is enabled or disabled in particular ClusterProfile,FeatureSet tuples. | ||
| It only needs a single pass over all the FeatureGated partial manifests. | ||
|
|
||
| If the schema generation isn't doing what you want, `manual-override-crd-manifests` allows partially overlaying bits of the CRD manifest. |
There was a problem hiding this comment.
Nit, might want to expand on what the expected format of the manual overrides is, but we also were light on the details in the tank patch example so this is I guess no worse
deads2k
force-pushed
the
by-gate-24-generator-docs
branch
from
b130b15
to
0ef9024
Compare
|
Updated |
deads2k
added
the
acknowledge-critical-fixes-only
|
/retest |
|
/lgtm We don't need e2e for a markdown only change |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/e2e-upgrade-minor In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@deads2k: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-cluster-config-api-container-v4.16.0-202403200942.p0.gb09bc66.assembly.stream.el9 for distgit ose-cluster-config-api. |
/assign @JoelSpeed
clear as mud.