Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NO-JIRA: remove single-node-developer clusterProfile #1827

Merged
merged 3 commits into from Mar 27, 2024
Merged

NO-JIRA: remove single-node-developer clusterProfile #1827

merged 3 commits into from Mar 27, 2024

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Mar 25, 2024

Per @wking this is not actually used, so let's clean up the cruft.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 25, 2024

Hello @deads2k! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 25, 2024
@openshift-ci openshift-ci bot requested review from cgwalters and dcbw March 25, 2024 16:10
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 25, 2024
@deads2k
Copy link
Contributor Author

deads2k commented Mar 25, 2024

/retest

@deads2k deads2k changed the title remove single-node-developer clusterProfile NO-JIRA: remove single-node-developer clusterProfile Mar 26, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 26, 2024
@openshift-ci-robot
Copy link

@deads2k: This pull request explicitly references no jira issue.

In response to this:

Per @wking this is not actually used, so let's clean up the cruft.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@deads2k deads2k added the lgtm Indicates that a PR is ready to be merged. label Mar 26, 2024
@deads2k
Copy link
Contributor Author

deads2k commented Mar 26, 2024

trevor linked justification in slack

wking
wking approved these changes Mar 26, 2024
View reviewed changes
Copy link
Member

@wking wking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

openshift/cluster-version-operator#685 gives the history of the single-node-developer profile, to show why nobody uses it anymore. And also with the cluster-version operator not annotating that profile on some important manifests, like the CVO's own Deployment, and not resulting in a number of cases like "hey, my cluster doesn't have a CVO?" confirms that the profile is not in use.

/lgtm

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 93d19f9 and 2 for PR HEAD 99851ab in total

@deads2k
Copy link
Contributor Author

deads2k commented Mar 26, 2024

/retest-required

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD ff84c2c and 1 for PR HEAD 99851ab in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 27, 2024

@deads2k: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 4b072d8 into openshift:master Mar 27, 2024
18 checks passed
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-config-api-container-v4.16.0-202403270213.p0.g4b072d8.assembly.stream.el9 for distgit ose-cluster-config-api.
All builds following this will include this PR.

stbenjam added a commit to stbenjam/api that referenced this pull request Mar 28, 2024
@stbenjam
Revert "Merge pull request openshift#1827 from deads2k/by-gate-29-sin…
a5f4f37 
…gle-node"

This reverts commit 4b072d8, reversing
changes made to ff84c2c.
stbenjam added a commit to stbenjam/api that referenced this pull request Mar 28, 2024
@stbenjam
Revert "Merge pull request openshift#1827 from deads2k/by-gate-29-sin…
7f29e31 
…gle-node"

This reverts commit 4b072d8, reversing
changes made to ff84c2c.
@candita candita mentioned this pull request May 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wking wking wking approved these changes

@cgwalters cgwalters Awaiting requested review from cgwalters

@dcbw dcbw Awaiting requested review from dcbw

Assignees

@wking wking

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@deads2k @openshift-ci-robot @openshift-bot @wking