Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

machineconfiguration/v1alpha1: add PinnedImageSetStatus #1830

Merged
merged 1 commit into from Mar 26, 2024
Merged

machineconfiguration/v1alpha1: add PinnedImageSetStatus #1830

merged 1 commit into from Mar 26, 2024

Conversation

hexfusion
Copy link
Contributor

@hexfusion hexfusion commented Mar 26, 2024 •
edited

This PR adds a basic status to PinnedImageSet. The reason for the status which would be unused would be to ensure a Generation is populated if a set is mutated.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 26, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 26, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 26, 2024

Hello @hexfusion! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 26, 2024
@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 26, 2024
@hexfusion hexfusion marked this pull request as ready for review March 26, 2024 16:19
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 26, 2024
@openshift-ci openshift-ci bot requested review from jkyros and soltysh March 26, 2024 16:20
@hexfusion
Copy link
Contributor Author

/test build

@hexfusion hexfusion changed the title machineconfiguration/v1: add PinnedImageSetStatus machineconfiguration/v1alpha1: add PinnedImageSetStatus Mar 26, 2024
deads2k
deads2k reviewed Mar 26, 2024
View reviewed changes
machineconfiguration/v1alpha1/types_pinnedimageset.go

// status describes the last observed state of this pinned image set.
// +optional
Status PinnedImageSetStatus `json:"status"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing status subresource in // + tags above?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gotcha kubebuilder adding

// +kubebuilder:subresource:status

@deads2k
Copy link
Contributor

deads2k commented Mar 26, 2024

neat that this didn't fail on e2e tests, but there's an e2e test that ensures schemas with status have status subresources.

@hexfusion
machineconfiguration/v1: add basic PinnedImageSetStatus
09f955f 
Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 26, 2024

@hexfusion: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@deads2k
Copy link
Contributor

deads2k commented Mar 26, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 26, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, hexfusion

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 26, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 93d19f9 into openshift:master Mar 26, 2024
9 checks passed
@hexfusion hexfusion deleted the pinned-image-status branch March 26, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k deads2k left review comments

@jkyros jkyros Awaiting requested review from jkyros

@soltysh soltysh Awaiting requested review from soltysh

Assignees

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hexfusion @deads2k