Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MON-3486: add feature gate for Collection Profiles #1835

Merged
merged 2 commits into from Mar 28, 2024

Conversation

jan--f
Copy link
Contributor

@jan--f jan--f commented Mar 27, 2024

Same as #1670 but dropping default enabled.

rexagod and others added 2 commits March 27, 2024 16:02
Adds a custom feature gate for CMO's Collection Profiles feature. Also
preserve the earlier behavior to enable it by default on TP enabled
clusters.

Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
Signed-off-by: Jan Fajerski <jfajersk@redhat.com>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 27, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 27, 2024

@jan--f: This pull request references MON-3486 which is a valid jira issue.

In response to this:

Same as #1670 but dropping default enabled.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jan--f
Copy link
Contributor Author

jan--f commented Mar 27, 2024

fyi @rexagod

Copy link
Contributor

openshift-ci bot commented Mar 27, 2024

Hello @jan--f! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 27, 2024
@openshift-ci openshift-ci bot requested review from knobunc and sjenning March 27, 2024 14:46
@deads2k
Copy link
Contributor

deads2k commented Mar 27, 2024

/lgtm
/approved

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2024
Copy link
Contributor

openshift-ci bot commented Mar 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, jan--f

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 27, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 4b072d8 and 2 for PR HEAD 1e5b8d6 in total

Copy link
Contributor

openshift-ci bot commented Mar 28, 2024

@jan--f: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit cd3ad5c into openshift:master Mar 28, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants