Add eligible CAPI-install platforms to TechPreview #1880
Conversation
- aws - nutanix - openstack - powervs - vsphere Have all passed e2e tests using the capi installer.
|
Skipping CI for Draft Pull Request. |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Hello @patrickdillon! Some important instructions when contributing to openshift/api: |
|
/test ? |
openshift-ci
bot
added
the
size/L
|
@patrickdillon: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test pull-ci-openshift-api-master-e2e-aws-ovn-techpreview We should see this fail with a message like: These dependencies will be resolved with openshift/installer#8343 (and the corresponding OSBS pr), in which case we can rerun this test and confirm it is working as expected. |
|
@patrickdillon: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
doh, I forgot that we won't see any installer changes until we vendor this, so I will create a corresponding installer pr |
|
/cc @JoelSpeed |
|
Created openshift/installer#8372 vendoring my local copy, and commented with proof of local testing |
|
/hold cancel Confirmed that the most recent nightly, https://amd64.ocp.releases.ci.openshift.org/releasestream/4.16.0-0.nightly/release/4.16.0-0.nightly-2024-05-08-222442 can now run the capi installer @JoelSpeed I think this is ready to move forward, or at least for review |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/test all Is it possible to trigger some cluster bot test workflows using this PR for PowerVS, OpenStack and Nutanix to prove we aren't breaking those by promoting these gates? |
|
@JoelSpeed: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/0440ffa0-0e17-11ef-9244-a8acec50993b-0 |
We can't test effectively only with this PR because it is essentially a no op until the changes are vendored to the installer, but I can try with openshift/installer#8372 I triggered e2e presubmits for nutanix and openstack to see if it breaks normal installs. There are apparently no powervs presubmits. I can try clusterbot to test if we break techpreview, but on the other hand, there are no existing tests for techpreview on openstack, nutanix or powervs, because my pr to add them was merged just yesterday. So we don't really have a baseline to compare it to. |
|
Clusterbot can only test openstack in techpreview:
|
|
Glad to see gating be used to good purpose. Targeted at TechPreview (not default), I'm in favor. /approve |
openshift-ci
bot
added
the
approved
|
/lgtm Release whenever you're ready |
openshift-ci
bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, patrickdillon, stbenjam The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
@patrickdillon: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-cluster-config-api-container-v4.16.0-202405100946.p0.g88a8afe.assembly.stream.el9 for distgit ose-cluster-config-api. |
Have all passed e2e tests using the capi installer.
Depends on openshift/installer#8343
Depends on https://issues.redhat.com/browse/CORS-3477