Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update protobuf generated files to fix verify job #414

Closed
wants to merge 1 commit into from

Conversation

dulek
Copy link
Contributor

@dulek dulek commented Aug 20, 2019

Seems like there was an upgrade of protoc (or libprotoc) in the CI's src
images. This causes the verify job to always fail as newly generated
files are different. This commit updates them to new version. Looks like
only the syntax of importing the packages is changed, so this commit
should not affect anything, beside unblocking the CI.

Seems like there was an upgrade of protoc (or libprotoc) in the CI's src
images. This causes the verify job to always fail as newly generated
files are different. This commit updates them to new version. Looks like
only the syntax of importing the packages is changed, so this commit
should not affect anything, beside unblocking the CI.
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 20, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dulek
To complete the pull request process, please assign soltysh
You can assign the PR to them by writing /assign @soltysh in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sttts
Copy link
Contributor

sttts commented Aug 20, 2019

/hold

until we understand why the pb output changed.

@dulek which protoc version did you use? Which platform?

Does our CI verify protobuf output?

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 20, 2019
@danwinship
Copy link
Contributor

Does our CI verify protobuf output?

yes, it's part of "make verify".

If you just make a dummy PR that doesn't change anything, it will currently fail ci/prow/verify, because the CI job thinks that the generated files should look different than they currently do in git

@dulek
Copy link
Contributor Author

dulek commented Aug 20, 2019

@sttts: And just to clarify - I just run the job manually and used whatever protoc was in verify container. I don't even know how to get that version, 3.0.x that verify-protobuf.sh requires is ancient anyway.

@sttts
Copy link
Contributor

sttts commented Aug 21, 2019

Go version of this repo is fixed now, to be 1.12.

@dulek
Copy link
Contributor Author

dulek commented Aug 21, 2019

@sttts: Does that fix the issue and render this commit obsolete?

@sttts
Copy link
Contributor

sttts commented Aug 21, 2019

#406 merged your pb changes already.

/close

@openshift-ci-robot
Copy link

@sttts: Closed this PR.

In response to this:

#406 merged your pb changes already.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dulek dulek deleted the fix-protobuf-verify branch August 21, 2019 08:49
@sttts
Copy link
Contributor

sttts commented Aug 21, 2019

Created #417 to test that CI is fine now.

@sttts
Copy link
Contributor

sttts commented Aug 21, 2019

#417 is green. So we are fine again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants