New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update protobuf generated files to fix verify job #414
Conversation
Seems like there was an upgrade of protoc (or libprotoc) in the CI's src images. This causes the verify job to always fail as newly generated files are different. This commit updates them to new version. Looks like only the syntax of importing the packages is changed, so this commit should not affect anything, beside unblocking the CI.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dulek The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold until we understand why the pb output changed. @dulek which protoc version did you use? Which platform? Does our CI verify protobuf output? |
yes, it's part of "make verify". If you just make a dummy PR that doesn't change anything, it will currently fail ci/prow/verify, because the CI job thinks that the generated files should look different than they currently do in git |
@sttts: And just to clarify - I just run the job manually and used whatever |
Go version of this repo is fixed now, to be 1.12. |
@sttts: Does that fix the issue and render this commit obsolete? |
#406 merged your pb changes already. /close |
@sttts: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Created #417 to test that CI is fine now. |
#417 is green. So we are fine again. |
Seems like there was an upgrade of protoc (or libprotoc) in the CI's src
images. This causes the verify job to always fail as newly generated
files are different. This commit updates them to new version. Looks like
only the syntax of importing the packages is changed, so this commit
should not affect anything, beside unblocking the CI.