Bug 1732144: Fix description of cluster build config #406
Conversation
|
@adambkaplan: This pull request references a valid Bugzilla bug. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
bugzilla/valid-bug
openshift-ci-robot
requested review from
spadgett,
abhinavdahiya and
derekwaynecarr
config/v1/types_build.go
Outdated
| @@ -9,7 +9,10 @@ import ( | |||
| // +genclient:nonNamespaced | |||
| // +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object | |||
|
|
|||
| // Build holds cluster-wide information on how to handle builds. The canonical name is `cluster` | |||
| // Build configures the behavior of OpenShift builds for the entire cluster. | |||
| // This includes default settings that can be overrode in BuildConfig objects, and overrides which are applied to all builds. | |||
There was a problem hiding this comment.
| // This includes default settings that can be overrode in BuildConfig objects, and overrides which are applied to all builds. | |
| // This includes default settings that can be overridden in BuildConfig objects, and overrides which are applied to all builds. |
There was a problem hiding this comment.
@bparees fixed.
Not necessary as we get the description from the OpenAPI schema served by the API server. But I believe a vendor bump is needed for cluster-config-operator. |
adambkaplan
force-pushed
the
config-build-desc
branch
from
debb795
to
1a1d37e
Compare
|
/lgtm |
openshift-ci-robot
added
lgtm
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@bparees looks like gofmt changed which caused verify to break. Kept the fix in a separate commit. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adambkaplan, bparees The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@adambkaplan: All pull requests linked via external trackers have merged. Bugzilla bug 1732144 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@bparees please don't merge global protobuf changes without deeper understanding of the reason. This puts customer data at risk (yes, I know this was only a formatting issue, but the root cause might be something critical). Thanks. |
ack. |
This fixes the description that appears in the OpenShift web console.
Also adding a deprecation notice for
AdditionalTrustedCA- this was never used in 4.1 but technically was not removed from the API.