-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CONSOLE-2376: Dynamic plugins for Console #764
CONSOLE-2376: Dynamic plugins for Console #764
Conversation
@jhadvig In addition to the operator config, we'll need the |
@spadgett only added the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold @ahardin-rh This will need documentation updates. |
What Jira is this connected to? |
/label docs-approved |
@ahardin-rh: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/label px-approved |
@sferich888: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
7c5cdd0
to
9979a0b
Compare
c8daaf5
to
6af85dc
Compare
group: console.openshift.io | ||
preserveUnknownFields: false | ||
versions: | ||
- name: v1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thinking if we should not put this to v1alpha1
, in case we decide to change any fields for 4.8
@spadgett thoughts ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We did say it would be alpha in the enhancement since it's only meant for internal use at this time.
0e633b7
to
3e2cb2e
Compare
/hold for approvals |
There have been small adjustments to the API change. PTAL |
3e2cb2e
to
4411942
Compare
LGTM from QE's point of view |
Adding qe-approved label based on this comment and QE approval of openshift/console#7360 which included the API change. /label qe-approved |
Adding the docs approved label now that it's available in the repo (see @ahardin-rh approval above). /label docs-approved |
@reestr PTAL |
/label px-approved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold cancel
Console and console operator PRs have been tested by QE and have all approvals.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bparees, jhadvig, spadgett, yapei The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Manually adding the |
API changes that are mapping the proposed enhancement doc. The enhancement is still not merged so creating a first draft of it's API changes
Will generate the crd yaml once we align on the API changes.
/assign @spadgett @bparees
https://issues.redhat.com/browse/CONSOLE-2377