Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CONSOLE-2376: Dynamic plugins for Console #764

Merged
merged 1 commit into from
Jan 12, 2021

Conversation

jhadvig
Copy link
Member

@jhadvig jhadvig commented Oct 20, 2020

API changes that are mapping the proposed enhancement doc. The enhancement is still not merged so creating a first draft of it's API changes

Will generate the crd yaml once we align on the API changes.

/assign @spadgett @bparees

https://issues.redhat.com/browse/CONSOLE-2377

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 20, 2020
@spadgett
Copy link
Member

@jhadvig In addition to the operator config, we'll need the ConsolePlugin CRD in the console.openshift.io API group.

@jhadvig
Copy link
Member Author

jhadvig commented Oct 21, 2020

@spadgett only added the ConsolePlugin type, for now... we can generate the CRD after we align on the working and the struct I guess ?

@jhadvig jhadvig changed the title [WIP] Dynamic plugins for Console Dynamic plugins for Console Oct 29, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 29, 2020
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@spadgett
Copy link
Member

/cc @christianvogt @vojtechszocs

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 29, 2020
@spadgett
Copy link
Member

/hold
/assign @yapei @ahardin-rh @sferich888
for approvals

@ahardin-rh This will need documentation updates.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 29, 2020
@sferich888
Copy link

What Jira is this connected to?

@ahardin-rh
Copy link

/label docs-approved

@openshift-ci-robot
Copy link

@ahardin-rh: The label(s) docs-approved cannot be applied, because the repository doesn't have them

In response to this:

/label docs-approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett changed the title Dynamic plugins for Console CONSOLE-2376: Dynamic plugins for Console Oct 29, 2020
@spadgett
Copy link
Member

@sferich888
Copy link

/label px-approved
/unassign @sferich888

@openshift-ci-robot
Copy link

@sferich888: The label(s) px-approved cannot be applied, because the repository doesn't have them

In response to this:

/label px-approved
/unassign @sferich888

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Nov 3, 2020
@jhadvig jhadvig force-pushed the dynamic_plugins branch 5 times, most recently from c8daaf5 to 6af85dc Compare December 8, 2020 18:37
group: console.openshift.io
preserveUnknownFields: false
versions:
- name: v1
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thinking if we should not put this to v1alpha1, in case we decide to change any fields for 4.8
@spadgett thoughts ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We did say it would be alpha in the enhancement since it's only meant for internal use at this time.

@jhadvig jhadvig force-pushed the dynamic_plugins branch 2 times, most recently from 0e633b7 to 3e2cb2e Compare January 4, 2021 16:35
@jhadvig
Copy link
Member Author

jhadvig commented Jan 6, 2021

/hold for approvals
/assign @ahardin-rh @yapei @sferich888 @reestr

@jhadvig
Copy link
Member Author

jhadvig commented Jan 6, 2021

There have been small adjustments to the API change. PTAL

@yapei
Copy link

yapei commented Jan 8, 2021

LGTM from QE's point of view

@spadgett
Copy link
Member

spadgett commented Jan 8, 2021

LGTM from QE's point of view

Adding qe-approved label based on this comment and QE approval of openshift/console#7360 which included the API change.

/label qe-approved

@openshift-ci-robot openshift-ci-robot added the qe-approved Signifies that QE has signed off on this PR label Jan 8, 2021
@spadgett
Copy link
Member

spadgett commented Jan 8, 2021

Adding the docs approved label now that it's available in the repo (see @ahardin-rh approval above).

/label docs-approved

@openshift-ci-robot openshift-ci-robot added the docs-approved Signifies that Docs has signed off on this PR label Jan 8, 2021
@jhadvig
Copy link
Member Author

jhadvig commented Jan 11, 2021

@reestr PTAL

@reestr
Copy link

reestr commented Jan 11, 2021

/label px-approved

@openshift-ci-robot openshift-ci-robot added the px-approved Signifies that Product Support has signed off on this PR label Jan 11, 2021
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold cancel

Console and console operator PRs have been tested by QE and have all approvals.

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jan 12, 2021
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, jhadvig, spadgett, yapei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spadgett
Copy link
Member

Manually adding the bugzilla/valid-bug label since the console team is piloting the new feature process that does not require a Bugzilla.

@spadgett spadgett added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jan 12, 2021
@openshift-merge-robot openshift-merge-robot merged commit 790e0a8 into openshift:master Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants