Bug 1993002: fix kubebuilder directives

[candita]

Add + to kubebuilder itself or it isn't observed
Capitalize validation directives Minimum and Maximum and put on separate lines
Use MinItems, not MinLength for array

[Miciah]

This needs a + to have the desired effect:

Suggested change

	// kubebuilder:validation:Minimum=0:Maximum=2147483647
	// +kubebuilder:validation:Minimum=0:Maximum=2147483647

[candita]

Thanks Miciah. There were multiple other errors that were hidden because of that. I think I caught them all.

[Miciah]

Looks like you got unlucky—the build scripts create temporary files with randomly generated names, and sometimes a randomly generated name has a prefix that causes it to be parsed as a number:

Error: unable to parse option "output:dir=/tmp/tmp.0xifVHmc4m": [hexadecimal literal has no digits (at <input>:1:10)]

/test verify

[candita]

Random filename string started with 0x and was treated like a hexadecimal?

_output/tools/bin/controller-gen-v0.6.0' schemapatch:manifests="./cloudnetwork/v1" paths="./cloudnetwork/v1" output:dir="/tmp/tmp.0xifVHmc4m"
Error: unable to parse option "output:dir=/tmp/tmp.0xifVHmc4m": [hexadecimal literal has no digits (at <input>:1:10)]

/test verify

[candita]

Looks like you got unlucky—the build scripts create temporary files with randomly generated names, and sometimes a randomly generated name has a prefix that causes it to be parsed as a number:

Error: unable to parse option "output:dir=/tmp/tmp.0xifVHmc4m": [hexadecimal literal has no digits (at <input>:1:10)]

/test verify

I saw this at the same time as you, how funny.

Does it lgty?

[Miciah]

Yup, lgtm, and the verify job passed.
/lgtm
/title Bug 1993002: fix kubebuilder directives

David, can you approve this PR? Just a quick follow-up to #958.
/assign @deads2k

[Miciah]

/retitle Bug 1993002: fix kubebuilder directives

[Miciah]

Hm, /title and /retitle aren't working. @candita, can you change the PR title to use a colon?

Never mind, the bot's just slow.

[openshift-ci]

@candita: This pull request references Bugzilla bug 1993002, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.9.0) matches configured target release for branch (4.9.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @quarterpin

In response to this:

Bug 1993002: fix kubebuilder directives

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[deads2k]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: candita, deads2k, Miciah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [deads2k]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@candita: All pull requests linked via external trackers have merged:

• openshift/api#988

Bugzilla bug 1993002 has been moved to the MODIFIED state.

In response to this:

Bug 1993002: fix kubebuilder directives

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.