Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.7] Bug 2022188: Image policy should mutate DeploymentConfigs and StatefulSets #73

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #72

/assign dmage

The image policy admission plugin should know about DeploymentConfigs
and should mutate StatefulSets not only on creation, but also on
update.
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 11, 2021

@openshift-cherrypick-robot: Bugzilla bug 2020644 has been cloned as Bugzilla bug 2022188. Retitling PR to link against new bug.
/retitle [release-4.7] [release-4.8] Bug 2022188: Image policy should mutate DeploymentConfigs and StatefulSets

In response to this:

[release-4.7] [release-4.8] Bug 2020644: Image policy should mutate DeploymentConfigs and StatefulSets

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.7] [release-4.8] Bug 2020644: Image policy should mutate DeploymentConfigs and StatefulSets [release-4.7] [release-4.8] Bug 2022188: Image policy should mutate DeploymentConfigs and StatefulSets Nov 11, 2021
@openshift-ci openshift-ci bot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Nov 11, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 11, 2021

@openshift-cherrypick-robot: This pull request references Bugzilla bug 2022188, which is invalid:

  • expected dependent Bugzilla bug 2020644 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.7] [release-4.8] Bug 2022188: Image policy should mutate DeploymentConfigs and StatefulSets

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Nov 11, 2021
@openshift-ci openshift-ci bot requested review from soltysh and sttts November 11, 2021 02:22
@dmage
Copy link
Member

dmage commented Nov 11, 2021

/retitle [release-4.7] Bug 2022188: Image policy should mutate DeploymentConfigs and StatefulSets

@openshift-ci openshift-ci bot changed the title [release-4.7] [release-4.8] Bug 2022188: Image policy should mutate DeploymentConfigs and StatefulSets [release-4.7] Bug 2022188: Image policy should mutate DeploymentConfigs and StatefulSets Nov 11, 2021
@dmage
Copy link
Member

dmage commented Nov 22, 2021

/bugzilla refresh

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Nov 22, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 22, 2021

@dmage: This pull request references Bugzilla bug 2022188, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.z) matches configured target release for branch (4.7.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2020644 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 2020644 targets the "4.8.z" release, which is one of the valid target releases: 4.8.0, 4.8.z
  • bug has dependents

Requesting review from QA contact:
/cc @xiuwang

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Nov 22, 2021
@openshift-ci openshift-ci bot requested a review from xiuwang November 22, 2021 10:04
@dmage
Copy link
Member

dmage commented Nov 22, 2021

/assign @soltysh

Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/label backport-risk-assessed

@openshift-ci openshift-ci bot added backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. lgtm Indicates that a PR is ready to be merged. labels Nov 23, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 23, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 23, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 23, 2021

@wangke19: The label(s) /label cherry-pick-approved. cannot be applied. These labels are supported: platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, downstream-change-needed, backport-risk-assessed, cherry-pick-approved

In response to this:

/label cherry-pick-approved.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wangke19
Copy link

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Nov 24, 2021
@openshift-merge-robot openshift-merge-robot merged commit cad1a43 into openshift:release-4.7 Nov 24, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 24, 2021

@openshift-cherrypick-robot: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with /bugzilla refresh.

Bugzilla bug 2022188 has not been moved to the MODIFIED state.

In response to this:

[release-4.7] Bug 2022188: Image policy should mutate DeploymentConfigs and StatefulSets

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dmage
Copy link
Member

dmage commented Nov 24, 2021

/cherrypick release-4.6

@openshift-cherrypick-robot
Copy link
Author

@dmage: new pull request created: #75

In response to this:

/cherrypick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants