Bug 2022188: Image policy should mutate DeploymentConfigs #261
Conversation
|
@dmage: An error was encountered querying GitHub for users with public email (xiuwang@redhat.com) for bug 2022188 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details. Full error message.
non-200 OK status code: 403 Forbidden body: "{\n \"documentation_url\": \"https://docs.github.com/en/free-pro-team@latest/rest/overview/resources-in-the-rest-api#secondary-rate-limits\",\n \"message\": \"You have exceeded a secondary rate limit. Please wait a few minutes before you try again.\"\n}\n"
Please contact an administrator to resolve this issue, then request a bug refresh with In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
|
/retest |
openshift-ci
bot
added
the
backport-risk-assessed
|
/assign @sttts |
|
Somebody from the team has to lgtm first. |
|
/assign @flavianmissi |
|
/lgtm |
openshift-ci
bot
added
the
qe-approved
|
@wangke19 Could you help add /label cherry-pick-approved ? Thanks |
|
/lgtm |
|
/bugzilla refresh |
|
/assign @wangke19 |
openshift-ci
bot
added
the
bugzilla/severity-high
|
@dmage: This pull request references Bugzilla bug 2022188, which is valid. 6 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
bugzilla/valid-bug
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dmage, flavianmissi, sttts, xiuwang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/label cherry-pick-approved |
openshift-ci
bot
added
the
cherry-pick-approved
|
@dmage: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged:
These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with Bugzilla bug 2022188 has not been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is a backport of #259 to address the bug 2022188.
Impact: Resolution of image stream names in deployment configs does not work because the image policy plugin does not know about them.
Cause: The problem exists since the beginning, but it wasn't visible as the image policy plugin used to resolve image streams names in all pods. Once we've fixed the bug 1925180, the plugin doesn't update controlled objects anymore, i.e. it doesn't update pods that are created for the deployment config.
Resolution: Update the admission plugin so that is aware of deployment configs.