Skip to content

Commit

Permalink
MGMT-16459: [STG] Cluster 4.15.0-rc.0 with HTTP Proxy failed on timeo…
Browse files Browse the repository at this point in the history
…ut due the failed to StartContainer for etcd with CrashLoopBackOff (#664)

If golang boolean flag has value, it must appear in the form
'--flag=<value>'.  In our case the value 'true' was appended after space
which caused the flag parser in assisted-installer to stop parsing.
This caused all the flags after this flag to be ignored which were the
proxy flags.
  • Loading branch information
ori-amizur committed Feb 22, 2024
1 parent 9c1a371 commit f39ebd0
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/commands/actions/install_cmd.go
Expand Up @@ -145,7 +145,7 @@ func (a *install) getFullInstallerCommand() string {
}

if a.installParams.EnableSkipMcoReboot {
installerCmdArgs = append(installerCmdArgs, "--enable-skip-mco-reboot", "true")
installerCmdArgs = append(installerCmdArgs, "--enable-skip-mco-reboot")
}

proxyArgs := getProxyArguments(a.installParams.Proxy)
Expand Down
2 changes: 1 addition & 1 deletion src/commands/actions/install_cmd_test.go
Expand Up @@ -246,7 +246,7 @@ var _ = Describe("installer test", func() {
installCommandRequest.EnableSkipMcoReboot = true
action := getInstall(installCommandRequest, filesystem, false)
args := action.Args()
Expect(strings.Join(args, " ")).To(ContainSubstring("--enable-skip-mco-reboot true"))
Expect(strings.Join(args, " ")).To(ContainSubstring("--enable-skip-mco-reboot"))
})

It("install no installer args", func() {
Expand Down

0 comments on commit f39ebd0

Please sign in to comment.