Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MGMT-16459: [STG] Cluster 4.15.0-rc.0 with HTTP Proxy failed on timeout due the failed to StartContainer for etcd with CrashLoopBackOff #664

Merged
merged 1 commit into from Feb 22, 2024

Conversation

ori-amizur
Copy link
Contributor

If golang boolean flag has value, it must appear in the form '--flag='. In our case the value 'true' was appended after space which caused the flag parser in assisted-installer to stop parsing. This caused all the flags after this flag to be ignored which were the proxy flags.

/cc @avishayt

…ut due the failed to StartContainer for etcd with CrashLoopBackOff

If golang boolean flag has value, it must appear in the form
'--flag=<value>'.  In our case the value 'true' was appended after space
which caused the flag parser in assisted-installer to stop parsing.
This caused all the flags after this flag to be ignored which were the
proxy flags.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 22, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 22, 2024

@ori-amizur: This pull request references MGMT-16459 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

If golang boolean flag has value, it must appear in the form '--flag='. In our case the value 'true' was appended after space which caused the flag parser in assisted-installer to stop parsing. This caused all the flags after this flag to be ignored which were the proxy flags.

/cc @avishayt

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from avishayt February 22, 2024 18:01
@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 22, 2024
Copy link

openshift-ci bot commented Feb 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ori-amizur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 22, 2024
Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.54%. Comparing base (9c1a371) to head (9919e6f).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #664      +/-   ##
==========================================
+ Coverage   60.48%   60.54%   +0.05%     
==========================================
  Files          74       74              
  Lines        3662     3662              
==========================================
+ Hits         2215     2217       +2     
+ Misses       1290     1289       -1     
+ Partials      157      156       -1     
Files Coverage Δ
src/commands/actions/install_cmd.go 91.24% <100.00%> (ø)

... and 1 file with indirect coverage changes

Copy link

openshift-ci bot commented Feb 22, 2024

@ori-amizur: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-agent-compact-ipv4 9919e6f link false /test e2e-agent-compact-ipv4

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@tsorya
Copy link
Contributor

tsorya commented Feb 22, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 22, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit f39ebd0 into openshift:master Feb 22, 2024
9 of 10 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-agent-installer-node-agent-container-v4.16.0-202402222239.p0.gf39ebd0.assembly.stream.el9 for distgit ose-agent-installer-node-agent.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants