New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MGMT-16459: [STG] Cluster 4.15.0-rc.0 with HTTP Proxy failed on timeout due the failed to StartContainer for etcd with CrashLoopBackOff #664
Conversation
…ut due the failed to StartContainer for etcd with CrashLoopBackOff If golang boolean flag has value, it must appear in the form '--flag=<value>'. In our case the value 'true' was appended after space which caused the flag parser in assisted-installer to stop parsing. This caused all the flags after this flag to be ignored which were the proxy flags.
@ori-amizur: This pull request references MGMT-16459 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ori-amizur The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #664 +/- ##
==========================================
+ Coverage 60.48% 60.54% +0.05%
==========================================
Files 74 74
Lines 3662 3662
==========================================
+ Hits 2215 2217 +2
+ Misses 1290 1289 -1
+ Partials 157 156 -1
|
@ori-amizur: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/lgtm |
f39ebd0
into
openshift:master
[ART PR BUILD NOTIFIER] This PR has been included in build ose-agent-installer-node-agent-container-v4.16.0-202402222239.p0.gf39ebd0.assembly.stream.el9 for distgit ose-agent-installer-node-agent. |
If golang boolean flag has value, it must appear in the form '--flag='. In our case the value 'true' was appended after space which caused the flag parser in assisted-installer to stop parsing. This caused all the flags after this flag to be ignored which were the proxy flags.
/cc @avishayt