Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-ISSUE: Remove unused function RemoveLV #552

Merged
merged 1 commit into from Sep 23, 2022

Conversation

javipolo
Copy link
Member

RemoveLV is not used anywhere, nor needed to cleanup LVM

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 22, 2022
@openshift-ci
Copy link

openshift-ci bot commented Sep 22, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 22, 2022
@javipolo
Copy link
Member Author

/cc @omertuc
/cc @carbonin

@omertuc
Copy link
Contributor

omertuc commented Sep 23, 2022

/lgtm

@omertuc
Copy link
Contributor

omertuc commented Sep 23, 2022

/approve

@openshift-ci
Copy link

openshift-ci bot commented Sep 23, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: javipolo, omertuc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels Sep 23, 2022
@javipolo javipolo marked this pull request as ready for review September 23, 2022 10:04
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 23, 2022
@codecov
Copy link

codecov bot commented Sep 23, 2022

Codecov Report

Merging #552 (b6fbcbe) into master (afcecef) will increase coverage by 0.09%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #552      +/-   ##
==========================================
+ Coverage   50.66%   50.76%   +0.09%     
==========================================
  Files          14       14              
  Lines        2765     2760       -5     
==========================================
  Hits         1401     1401              
+ Misses       1225     1220       -5     
  Partials      139      139              
Impacted Files Coverage Δ
src/ops/ops.go 11.91% <ø> (+0.13%) ⬆️

@openshift-ci
Copy link

openshift-ci bot commented Sep 23, 2022

@javipolo: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 149576a into openshift:master Sep 23, 2022
@javipolo javipolo deleted the cleanup-removelv branch September 27, 2022 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants