OCPBUGSM-30853: Change default telemeter server of installed clusters to prod. #1988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ybettan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
ybettan
force-pushed
the
redirect-telemeter
branch
from
33d1650
to
8b50d61
Compare
ybettan
changed the title
ybettan
force-pushed
the
redirect-telemeter
branch
4 times, most recently
from
8199375
to
73c9e62
Compare
ybettan
changed the title
mkowalski
reviewed
Jun 14, 2021
| stageServiceBaseURL = "https://api.stage.openshift.com" | ||
| integrationServiceBaseURL = "https://api.integration.openshift.com" | ||
| stageTelemeterURL = "https://infogw.api.stage.openshift.com" | ||
| dummyURL = "https://dummy.com" |
There was a problem hiding this comment.
Not blocking, but how about using stuff from .invalid TLD instead of domain that is registered to someone somewhere? It should not matter much until we decide to send there (accidentally or not) some data that we should not
There was a problem hiding this comment.
I don't see any reason why not to use https://dummy.invalid.
Anyway, I want to keep this PR minimal as possible - only the bug fix.
What you see is only the indention change but this wasn't inserted in this PR.
@mkowalski
Thanks for your review BTW, I have learned something new :)
There was a problem hiding this comment.
@mkowalski @ybettan can one of you open an issue to track this? Or a PR to fix it?
I think this is a great point.
There was a problem hiding this comment.
I have opened #1993 for that
… to prod.
Until now, in the service, we changed the default behavior of openshift,
which is to always send cluster metrics to prod-telemeter-server unless
changed by the user, and we:
* left untouched clusters created by cloud prod env
* redirected to telemeter-stage stage clusters
* redirected to dummy-url all other clusters
The issue with this approach is that all prod clusters that aren't
created in the cloud, operator clusters for example, will fail to
deliver telemetry.
Instead, we will now default to prod-telemeter instead of dummy-url
unless we know better:
* left untouched clusters created by ALL prod envs (not just cloud)
* redirect to telemeter-stage stage clusters
* redirect to dummy-url integration clusters
Signed-off-by: Yoni Bettan <ybettan@redhat.com>
ybettan
force-pushed
the
redirect-telemeter
branch
from
73c9e62
to
5740ac0
Compare
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
ybettan
added a commit
to ybettan/assisted-service
that referenced
this pull request
Jun 15, 2021
… to prod. (openshift#1988) Until now, in the service, we changed the default behavior of openshift, which is to always send cluster metrics to prod-telemeter-server unless changed by the user, and we: * left untouched clusters created by cloud prod env * redirected to telemeter-stage stage clusters * redirected to dummy-url all other clusters The issue with this approach is that all prod clusters that aren't created in the cloud, operator clusters for example, will fail to deliver telemetry. Instead, we will now default to prod-telemeter instead of dummy-url unless we know better: * left untouched clusters created by ALL prod envs (not just cloud) * redirect to telemeter-stage stage clusters * redirect to dummy-url integration clusters Signed-off-by: Yoni Bettan <ybettan@redhat.com>
18 tasks
ybettan
added a commit
to ybettan/assisted-service
that referenced
this pull request
Jun 15, 2021
… to prod. (openshift#1988) Until now, in the service, we changed the default behavior of openshift, which is to always send cluster metrics to prod-telemeter-server unless changed by the user, and we: * left untouched clusters created by cloud prod env * redirected to telemeter-stage stage clusters * redirected to dummy-url all other clusters The issue with this approach is that all prod clusters that aren't created in the cloud, operator clusters for example, will fail to deliver telemetry. Instead, we will now default to prod-telemeter instead of dummy-url unless we know better: * left untouched clusters created by ALL prod envs (not just cloud) * redirect to telemeter-stage stage clusters * redirect to dummy-url integration clusters Signed-off-by: Yoni Bettan <ybettan@redhat.com>
ybettan
added a commit
to ybettan/assisted-service
that referenced
this pull request
Jun 15, 2021
… prod. (openshift#1988) Until now, in the service, we changed the default behavior of openshift, which is to always send cluster metrics to prod-telemeter-server unless changed by the user, and we: * left untouched clusters created by cloud prod env * redirected to telemeter-stage stage clusters * redirected to dummy-url all other clusters The issue with this approach is that all prod clusters that aren't created in the cloud, operator clusters for example, will fail to deliver telemetry. Instead, we will now default to prod-telemeter instead of dummy-url unless we know better: * left untouched clusters created by ALL prod envs (not just cloud) * redirect to telemeter-stage stage clusters * redirect to dummy-url integration clusters Signed-off-by: Yoni Bettan <ybettan@redhat.com>
18 tasks
openshift-merge-robot
pushed a commit
that referenced
this pull request
Jun 17, 2021
… prod. (#1988) (#2003) Until now, in the service, we changed the default behavior of openshift, which is to always send cluster metrics to prod-telemeter-server unless changed by the user, and we: * left untouched clusters created by cloud prod env * redirected to telemeter-stage stage clusters * redirected to dummy-url all other clusters The issue with this approach is that all prod clusters that aren't created in the cloud, operator clusters for example, will fail to deliver telemetry. Instead, we will now default to prod-telemeter instead of dummy-url unless we know better: * left untouched clusters created by ALL prod envs (not just cloud) * redirect to telemeter-stage stage clusters * redirect to dummy-url integration clusters Signed-off-by: Yoni Bettan <ybettan@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What environments does this code impact?
How was this code tested?
Please, select one or more if needed:
It's recommended to take a few extra minutes to provide more information about
how this code was tested. Here are some questions that may be worth answering:
Manual system tests:
I have run test-infra locally and we can see that no manifest was created to redirect the metrics (we defaulted to prod):
Also, in the created cluster, we can see that the ConfigMap for redirection wasn't created:
Assignees
Please, add one or two reviewers that could help review this PR.
/assign @
/assign @
Checklist
docs, README, etc)Reviewers Checklist