Bug 1971589: Change default telemeter server of installed clusters to prod. (#1988) #2003

ybettan · 2021-06-15T06:58:10Z

Description

Until now, in the service, we changed the default behavior of openshift,
which is to always send cluster metrics to prod-telemeter-server unless
changed by the user, and we:
* left untouched clusters created by cloud prod env
* redirected to telemeter-stage stage clusters
* redirected to dummy-url all other clusters

The issue with this approach is that all prod clusters that aren't
created in the cloud, operator clusters for example, will fail to
deliver telemetry.

Instead, we will now default to prod-telemeter instead of dummy-url
unless we know better:
* left untouched clusters created by ALL prod envs (not just cloud)
* redirect to telemeter-stage stage clusters
* redirect to dummy-url integration clusters

Signed-off-by: Yoni Bettan ybettan@redhat.com

This PR clones #1988 and was cherry-picked from it to this specific branch.

What environments does this code impact?

Automation (CI, tools, etc)
Cloud
Operator Managed Deployments
None

How was this code tested?

Please, select one or more if needed:

assisted-test-infra environment
dev-scripts environment
Reviewer's test appreciated
Waiting for CI to do a full test run
Manual (Elaborate on how it was tested)
No tests needed

It's recommended to take a few extra minutes to provide more information about
how this code was tested. Here are some questions that may be worth answering:

Manual system tests:

I have run test-infra locally and we can see that no manifest was created to redirect the metrics (we defaulted to prod):

$ curl -s $(minikube service assisted-service -n assisted-installer --url)/api/assisted-install/v1/clusters/baa05cab-8b82-41e0-aef2-6771e350c2d2/manifests | jq '.'
[
  {
    "file_name": "50-masters-chrony-configuration.yaml",
    "folder": "openshift"
  },
  {
    "file_name": "50-workers-chrony-configuration.yaml",
    "folder": "openshift"
  }
]

Also, in the created cluster, we can see that the ConfigMap for redirection wasn't created:

$ oc --kubeconfig kubeconfig describe cm/cluster-monitoring-config -n openshift-monitoring
Error from server (NotFound): configmaps "cluster-monitoring-config" not found

Should this PR be tested by the reviewer?
Is this PR relying on CI for an e2e test run?
Should this PR be tested in a specific environment?
Any logs, screenshots, etc that can help with the review process?

Assignees

Please, add one or two reviewers that could help review this PR.

/assign @
/assign @

Checklist

Title and description added to both, commit and PR.
Relevant issues have been associated (see CONTRIBUTING guide)
Reviewers have been listed
This change does not require a documentation update (docstring, docs, README, etc)
Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

Are the title and description (in both PR and commit) meaningful and clear?
Is there a bug required (and linked) for this change?
Should this PR be backported?

ybettan · 2021-06-15T06:59:12Z

/assign @ronniel1
/assisgn @gamli75

ronniel1

/lgtm

openshift-ci · 2021-06-15T07:23:12Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ronniel1, ybettan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [ronniel1]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

… prod. (openshift#1988) Until now, in the service, we changed the default behavior of openshift, which is to always send cluster metrics to prod-telemeter-server unless changed by the user, and we: * left untouched clusters created by cloud prod env * redirected to telemeter-stage stage clusters * redirected to dummy-url all other clusters The issue with this approach is that all prod clusters that aren't created in the cloud, operator clusters for example, will fail to deliver telemetry. Instead, we will now default to prod-telemeter instead of dummy-url unless we know better: * left untouched clusters created by ALL prod envs (not just cloud) * redirect to telemeter-stage stage clusters * redirect to dummy-url integration clusters Signed-off-by: Yoni Bettan <ybettan@redhat.com>

openshift-ci · 2021-06-15T08:01:38Z

@ybettan: This pull request references Bugzilla bug 1971589, which is invalid:

expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is MODIFIED instead
expected dependent Bugzilla bug 1971312 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ybettan · 2021-06-15T08:09:27Z

/bugzilla refresh

openshift-ci · 2021-06-15T08:09:32Z

@ybettan: This pull request references Bugzilla bug 1971589, which is invalid:

expected dependent Bugzilla bug 1971312 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ybettan · 2021-06-15T08:11:55Z

/bugzilla refresh

openshift-ci · 2021-06-15T08:11:59Z

@ybettan: This pull request references Bugzilla bug 1971589, which is invalid:

expected dependent Bugzilla bug 1971312 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

flaper87 · 2021-06-15T08:24:54Z

@ybettan could you please fix the PR description? The title is broken, the description is out of the section, no flags are selected.

I saw the master PR is linked but it would be better to have a small heading for it.

Holding for now while this is fixed. Thank you, 🙏

/hold

openshift-ci · 2021-06-15T08:42:54Z

@ybettan: This pull request references Bugzilla bug 1971589, which is invalid:

expected dependent Bugzilla bug 1971312 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2021-06-15T08:43:06Z

@ybettan: This pull request references Bugzilla bug 1971589, which is invalid:

expected dependent Bugzilla bug 1971312 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2021-06-15T08:43:08Z

@ybettan: This pull request references Bugzilla bug 1971589, which is invalid:

expected dependent Bugzilla bug 1971312 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2021-06-15T08:43:09Z

@ybettan: This pull request references Bugzilla bug 1971589, which is invalid:

expected dependent Bugzilla bug 1971312 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2021-06-15T08:43:21Z

@ybettan: This pull request references Bugzilla bug 1971589, which is invalid:

expected dependent Bugzilla bug 1971312 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2021-06-15T08:43:25Z

@ybettan: This pull request references Bugzilla bug 1971589, which is invalid:

expected dependent Bugzilla bug 1971312 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-06-15T13:31:39Z

/retest

Please review the full test history for this PR and help us cut down flakes.

ybettan · 2021-06-15T13:52:24Z

/retest

openshift-bot · 2021-06-15T14:55:38Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-06-15T15:07:39Z

/retest

Please review the full test history for this PR and help us cut down flakes.

ybettan · 2021-06-15T15:23:08Z

/retest

ybettan · 2021-06-15T15:24:27Z

/test subsystem-kubeapi-aws

openshift-ci · 2021-06-15T15:25:03Z

@ybettan: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

/test ci-index
/test e2e-metal-assisted-kube-api
/test e2e-metal-assisted-operator-disconnected
/test e2e-metal-assisted-operator-ztp
/test images
/test lint
/test subsystem-aws
/test subsystem-kubeapi-aws

Use /test all to run all jobs.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ybettan · 2021-06-15T17:18:16Z

/test subsystem-aws

ybettan · 2021-06-15T18:52:27Z

/test subsystem-kubeapi-aws

openshift-bot · 2021-06-15T18:56:38Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-06-15T21:11:45Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-06-16T00:23:39Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-06-16T01:02:38Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-06-16T01:16:32Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-06-16T01:28:38Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-06-16T01:41:41Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-06-16T02:56:29Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-06-16T03:08:31Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-06-16T04:11:30Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-06-16T04:37:32Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-06-16T05:29:29Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-06-16T06:08:31Z

/retest

Please review the full test history for this PR and help us cut down flakes.

ybettan · 2021-06-16T08:55:58Z

/test e2e-metal-assisted-operator-ztp

gamli75 · 2021-06-16T13:26:23Z

/test subsystem-kubeapi-aws

openshift-bot · 2021-06-17T01:19:30Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-06-17T02:47:19Z

/retest

Please review the full test history for this PR and help us cut down flakes.

gamli75 · 2021-06-17T05:08:51Z

/test subsystem-kubeapi-aws

openshift-ci · 2021-06-17T06:34:16Z

@ybettan: All pull requests linked via external trackers have merged:

openshift/assisted-service#2003

Bugzilla bug 1971589 has been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot requested review from romfreiman and ronniel1 June 15, 2021 06:58

openshift-ci bot assigned ronniel1 Jun 15, 2021

ronniel1 approved these changes Jun 15, 2021

View reviewed changes

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 15, 2021

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 15, 2021

ybettan force-pushed the ocm-2.3 branch from 956bb02 to 2332c2e Compare June 15, 2021 07:53

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 15, 2021

ybettan changed the title ~~OCPBUGSM-30853: Change default telemeter server of installed clusters…~~ OCPBUGSM-30872: Change default telemeter server of installed clusters… Jun 15, 2021

ybettan force-pushed the ocm-2.3 branch from 2332c2e to 7699d57 Compare June 15, 2021 08:00

ybettan changed the title ~~OCPBUGSM-30872: Change default telemeter server of installed clusters…~~ Bug 1971589: Change default telemeter server of installed clusters… Jun 15, 2021

openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jun 15, 2021

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 15, 2021

ybettan changed the title ~~Bug 1971589: Change default telemeter server of installed clusters…~~ Bug 1971589: Change default telemeter server of installed clusters to prod. (#1988) Jun 15, 2021

openshift-merge-robot merged commit 8b3bb96 into openshift:ocm-2.3 Jun 17, 2021

ybettan deleted the ocm-2.3 branch June 20, 2021 07:23

Bug 1971589: Change default telemeter server of installed clusters to prod. (#1988) #2003

Bug 1971589: Change default telemeter server of installed clusters to prod. (#1988) #2003

Conversation

ybettan commented Jun 15, 2021 • edited

Description

What environments does this code impact?

How was this code tested?

Assignees

Checklist

Reviewers Checklist

ybettan commented Jun 15, 2021

ronniel1 left a comment

Choose a reason for hiding this comment

openshift-ci bot commented Jun 15, 2021

openshift-ci bot commented Jun 15, 2021

ybettan commented Jun 15, 2021

openshift-ci bot commented Jun 15, 2021

ybettan commented Jun 15, 2021

openshift-ci bot commented Jun 15, 2021

flaper87 commented Jun 15, 2021

openshift-ci bot commented Jun 15, 2021

openshift-ci bot commented Jun 15, 2021

openshift-ci bot commented Jun 15, 2021

openshift-ci bot commented Jun 15, 2021

openshift-ci bot commented Jun 15, 2021

openshift-ci bot commented Jun 15, 2021

openshift-bot commented Jun 15, 2021

ybettan commented Jun 15, 2021

openshift-bot commented Jun 15, 2021

openshift-bot commented Jun 15, 2021

ybettan commented Jun 15, 2021

ybettan commented Jun 15, 2021

openshift-ci bot commented Jun 15, 2021

ybettan commented Jun 15, 2021

ybettan commented Jun 15, 2021

openshift-bot commented Jun 15, 2021

openshift-bot commented Jun 15, 2021

openshift-bot commented Jun 16, 2021

openshift-bot commented Jun 16, 2021

openshift-bot commented Jun 16, 2021

openshift-bot commented Jun 16, 2021

openshift-bot commented Jun 16, 2021

openshift-bot commented Jun 16, 2021

openshift-bot commented Jun 16, 2021

openshift-bot commented Jun 16, 2021

openshift-bot commented Jun 16, 2021

openshift-bot commented Jun 16, 2021

openshift-bot commented Jun 16, 2021

ybettan commented Jun 16, 2021

gamli75 commented Jun 16, 2021

openshift-bot commented Jun 17, 2021

openshift-bot commented Jun 17, 2021

gamli75 commented Jun 17, 2021

openshift-ci bot commented Jun 17, 2021

ybettan commented Jun 15, 2021 •

edited