Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AGENT-205: Use of internal package fails OCP build #3837

Conversation

pawanpinjarkar
Copy link
Contributor

The OCP build ART-4060 fails due to the use of an internal package.

Ref:
brew task https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=45260777
https://download.eng.bos.redhat.com/brewroot/work/tasks/777/45260777/x86_64.log

List all the issues related to this PR

  • New Feature
  • Enhancement
  • Bug fix
  • Tests
  • Documentation
  • CI/CD

What environments does this code impact?

  • Automation (CI, tools, etc)
  • Cloud
  • Operator Managed Deployments
  • None

How was this code tested?

  • assisted-test-infra environment
  • dev-scripts environment
  • Reviewer's test appreciated
  • Waiting for CI to do a full test run
  • Manual (Elaborate on how it was tested)
  • No tests needed

Assignees

/cc @
/cc @

Checklist

  • Title and description added to both, commit and PR.
  • Relevant issues have been associated (see CONTRIBUTING guide)
  • Reviewers have been listed
  • This change does not require a documentation update (docstring, docs, README, etc)
  • Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

  • Are the title and description (in both PR and commit) meaningful and clear?
  • Is there a bug required (and linked) for this change?
  • Should this PR be backported?

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 19, 2022
@openshift-ci
Copy link

openshift-ci bot commented May 19, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pawanpinjarkar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 19, 2022
@openshift-ci openshift-ci bot requested review from empovit and tsorya May 19, 2022 20:44
@pawanpinjarkar
Copy link
Contributor Author

/cc @osherdp @omertuc

@openshift-ci openshift-ci bot requested review from omertuc and osherdp May 19, 2022 20:44
@openshift-ci
Copy link

openshift-ci bot commented May 19, 2022

@pawanpinjarkar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/edge-subsystem-kubeapi-aws b280cce link true /test edge-subsystem-kubeapi-aws
ci/prow/edge-unit-test b280cce link true /test edge-unit-test
ci/prow/images b280cce link true /test images
ci/prow/edge-e2e-metal-assisted-operator-ztp b280cce link true /test edge-e2e-metal-assisted-operator-ztp
ci/prow/edge-ci-index b280cce link true /test edge-ci-index
ci/prow/edge-images b280cce link true /test edge-images
ci/prow/edge-subsystem-aws b280cce link true /test edge-subsystem-aws
ci/prow/edge-e2e-metal-assisted b280cce link true /test edge-e2e-metal-assisted
ci/prow/edge-lint b280cce link true /test edge-lint
ci/prow/edge-verify-generated-code b280cce link true /test edge-verify-generated-code

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pawanpinjarkar
Copy link
Contributor Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 19, 2022
@pawanpinjarkar
Copy link
Contributor Author

While this PR tries to fix the ART build issue, I am trying to see if there are any other alternatives.

@openshift-ci
Copy link

openshift-ci bot commented May 21, 2022

@pawanpinjarkar: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 21, 2022
@omertuc
Copy link
Contributor

omertuc commented May 23, 2022

I'm against merging this, such directory rename could break a lot of hyperlinks to code files and would be confusing when following git blame, it should be avoided

@osherdp
Copy link
Contributor

osherdp commented May 23, 2022

Seems like it's not needed, #3839 sets WORK_DIR instead (and apart from the patched oc thing seems legit)

@lranjbar
Copy link
Contributor

@pawanpinjarkar Take a look at #3839 from ART when you are able to. 😃 I think this is the route we will have to take for now.

@lranjbar lranjbar closed this May 23, 2022
@pawanpinjarkar pawanpinjarkar deleted the multi-arch-support-for-ocp-build branch May 25, 2022 13:52
@pawanpinjarkar
Copy link
Contributor Author

Thanks for looking into this problem while I was sick. The PR was not meant to be merged when created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants