-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AGENT-205: Use of internal package fails OCP build #3837
AGENT-205: Use of internal package fails OCP build #3837
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pawanpinjarkar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@pawanpinjarkar: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/hold |
While this PR tries to fix the ART build issue, I am trying to see if there are any other alternatives. |
@pawanpinjarkar: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I'm against merging this, such directory rename could break a lot of hyperlinks to code files and would be confusing when following git blame, it should be avoided |
Seems like it's not needed, #3839 sets |
@pawanpinjarkar Take a look at #3839 from ART when you are able to. 😃 I think this is the route we will have to take for now. |
Thanks for looking into this problem while I was sick. The PR was not meant to be merged when created. |
The OCP build ART-4060 fails due to the use of an internal package.
Ref:
brew task https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=45260777
https://download.eng.bos.redhat.com/brewroot/work/tasks/777/45260777/x86_64.log
List all the issues related to this PR
What environments does this code impact?
How was this code tested?
Assignees
/cc @
/cc @
Checklist
docs
, README, etc)Reviewers Checklist