AGENT-205: Fix OCP image build

[vfreex]

List all the issues related to this PR

• New Feature
• Enhancement
• Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• None

How was this code tested?

• assisted-test-infra environment
• dev-scripts environment
• Reviewer's test appreciated
• Waiting for CI to do a full test run
• Manual (Elaborate on how it was tested)
• No tests needed

Assignees

/cc @
/cc @

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see CONTRIBUTING guide)
• Reviewers have been listed
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

[osherdp]

I think usage of quay.io/ocpmetal/oc-image:bug-1823143-multi-arch-ai-bug-2069976 should be preserved, as the changes didn't get into oc 4.11
/hold
(just until we figure out the status of this patch, everything else looks good :) )

[eranco74]

/hold
We need the custom oc for supporting installation with mirror registry

[lranjbar]

/retest

[codecov]

Codecov Report

Merging #3839 (76cdab7) into master (1611544) will increase coverage by 2.51%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3839      +/-   ##
==========================================
+ Coverage   66.33%   68.85%   +2.51%     
==========================================
  Files         175      178       +3     
  Lines       24629    27308    +2679     
==========================================
+ Hits        16338    18802    +2464     
- Misses       6777     6910     +133     
- Partials     1514     1596      +82     

Impacted Files	Coverage Δ
internal/network/family_utils.go	50.00% <0.00%> (-12.50%)	⬇️
...nal/controller/controllers/bmh_agent_controller.go	62.38% <0.00%> (-0.45%)	⬇️
internal/ignition/ignition.go	57.50% <0.00%> (-0.33%)	⬇️
internal/common/db.go	0.00% <0.00%> (ø)
internal/host/conditions.go	100.00% <0.00%> (ø)
internal/provider/ovirt/inventory.go	0.00% <0.00%> (ø)
internal/common/test_configuration.go	0.00% <0.00%> (ø)
internal/provider/vsphere/inventory.go	0.00% <0.00%> (ø)
...rnal/controller/controllers/infraenv_controller.go	60.48% <0.00%> (ø)
internal/ignition/ironic.go	100.00% <0.00%> (ø)
... and 17 more

[lranjbar]

/approve

Please note that this change is only to Dockerfile.assisted-service.ocp which is the assisted-service image landing in the OCP payload. From what I understand the Openshift policy is: "All the images in the OCP payload have to use the other official images in the OCP payload." We will have to get this fix in the official oc image in the OCP payload to support disconnected environments.

In the meantime, we need to have this image built by ART so that we can start testing the OCP payload official image for assisted-service properly. I will let others from the Openshift Agent Team weigh in on this but while this is unfortunate that this bug is still not fixed... this is likely the path forward for us.

@vfreex Thank you for opening this PR for us. 😃

Agent team: @dhellmann @zaneb @rwsu @pawanpinjarkar @andfasano @bfournie @celebdor

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lranjbar, vfreex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [lranjbar]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[zaneb]

If this just prevents us from doing disconnected installs then I think it is the right way to move forward for now. We may have to re-evaluate if the bug doesn't get a timely fix, but anything is better than nothing.
If the way that assisted-service interacts with the CLI does not work with the standard binary (e.g. passes a command-line argument that will be rejected?) then we might need to find another approach even in the short term. That's not going to involve using a base image from quay though, so I think we should go ahead with this change in either case.

/hold cancel

[andfasano]

/retest

[lranjbar]

/retest

[lranjbar]

/retest

[empovit]

/uncc empovit

[lranjbar]

JIRA issue tracker: AGENT-205

[pawanpinjarkar]

/lgtm

[openshift-bot]

/retest-required

Please review the full test history for this PR and help us cut down flakes.

[openshift-ci]

@vfreex: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.