MGMT-11753: moving CI Dockerfiles to the repo #4386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
openshift-ci
bot
added
size/M
|
/hold |
openshift-ci
bot
added
do-not-merge/hold
Codecov Report
@@ Coverage Diff @@
## master #4386 +/- ##
==========================================
+ Coverage 66.45% 66.70% +0.24%
==========================================
Files 193 196 +3
Lines 27074 27355 +281
==========================================
+ Hits 17993 18247 +254
- Misses 7455 7476 +21
- Partials 1626 1632 +6
|
nmagnezi
reviewed
Sep 14, 2022
|
/uncc nbalacha romfreiman |
openshift-ci
bot
requested review from
adriengentil
and removed request for
romfreiman and
nbalacha
In order to be able to do quick fixes with less rehearse jobs and to spot duplicated code, we should have all CI-related images inside the repository (currently it's configured ad-hoc in the ``openshift/release`` repo). This mainly copies the Dockerfiles to this repo without any significant changes.
osherdp
force-pushed
the
refactor/move-dockerfiles-to-repository
branch
from
39f2350
to
8995ba7
Compare
|
@osherdp: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
adriengentil
approved these changes
Sep 20, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adriengentil, osherdp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Tests seem to be passing with the new configuration: (except a few unrelated errors) /unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
osherdp
added a commit
to osherdp/release
that referenced
this pull request
Sep 20, 2022
In order to be able to do quick fixes with less rehearse jobs and to spot duplicated code, we should have all CI-related images inside the repository (currently it's configured ad-hoc in the openshift/release repo). This change uses the already-moved Dockerfiles from the repository (as done in openshift/assisted-service#4386).
openshift-merge-robot
pushed a commit
to openshift/release
that referenced
this pull request
Sep 22, 2022
In order to be able to do quick fixes with less rehearse jobs and to spot duplicated code, we should have all CI-related images inside the repository (currently it's configured ad-hoc in the openshift/release repo). This change uses the already-moved Dockerfiles from the repository (as done in openshift/assisted-service#4386).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to be able to do quick fixes with less rehearse jobs and to spot duplicated code, we should have all CI-related images inside the repository (currently it's configured ad-hoc in the
openshift/releaserepo).This mainly copies the Dockerfiles to this repo without any significant changes.
List all the issues related to this PR
What environments does this code impact?
How was this code tested?
Checklist
docs, README, etc)Reviewers Checklist