MGMT-10678: Enable upgrade agent by default

[jhernand]

The upgrade agent feature has been explicitly enabled in the SaaS environments. This patch enables it by default in all the other environments. It will still be possible to disable it setting the ENABLE_UPGRADE_AGENT environment variable to false.

Related: https://issues.redhat.com/browse/MGMT-10678

List all the issues related to this PR

• New Feature
• Enhancement
• Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• None

How was this code tested?

• assisted-test-infra environment
• dev-scripts environment
• Reviewer's test appreciated
• Waiting for CI to do a full test run
• Manual (Elaborate on how it was tested)
• No tests needed

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see CONTRIBUTING guide)
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

[codecov]

Codecov Report

Merging #4655 (4efed61) into master (9ce4e3c) will decrease coverage by 0.06%.
The diff coverage is n/a.

❗ Current head 4efed61 differs from pull request most recent head 751cdaf. Consider uploading reports for the commit 751cdaf to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4655      +/-   ##
==========================================
- Coverage   67.02%   66.95%   -0.07%     
==========================================
  Files         200      200              
  Lines       28559    28436     -123     
==========================================
- Hits        19141    19040     -101     
+ Misses       7679     7662      -17     
+ Partials     1739     1734       -5     

Impacted Files	Coverage Δ
...rnal/controller/controllers/infraenv_controller.go	61.79% <0.00%> (-1.71%)	⬇️
internal/ignition/ignition.go	58.05% <0.00%> (-0.58%)	⬇️
internal/host/validator.go	80.10% <0.00%> (-0.47%)	⬇️
...oller/controllers/agentserviceconfig_controller.go	84.85% <0.00%> (-0.13%)	⬇️
internal/bminventory/inventory.go	69.25% <0.00%> (-0.05%)	⬇️
internal/oc/release.go	78.36% <0.00%> (+0.90%)	⬆️
internal/cluster/validations/validations.go	45.18% <0.00%> (+1.54%)	⬆️
internal/versions/versions.go	92.20% <0.00%> (+2.33%)	⬆️

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: filanov, jhernand

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [filanov,jhernand]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD a85c336 and 2 for PR HEAD f0ffedf in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 4efed61 and 1 for PR HEAD f0ffedf in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD feadbb0 and 0 for PR HEAD f0ffedf in total

[openshift-ci-robot]

/hold

Revision f0ffedf was retested 3 times: holding

[openshift-ci]

New changes are detected. LGTM label has been removed.

[jhernand]

The tests were failing because the mock agent wasn't sending the agent version. I have fixed that.

[jhernand]

/test edge-e2e-ai-operator-ztp

[filanov]

Can it be unhold?

[openshift-merge-robot]

@jhernand: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[openshift-bot]

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

[openshift-ci]

@jhernand: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-agent-compact	751cdaf	link	true	/test e2e-agent-compact
ci/prow/e2e-agent-compact-ipv4	751cdaf	link	true	/test e2e-agent-compact-ipv4

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.