MGMT-14769: Enable upgrade agent by default

[jhernand]

The upgrade agent feature has been explicitly enabled in the SaaS environments. This patch enables it by default in all the other environments. It will still be possible to disable it setting the ENABLE_UPGRADE_AGENT environment variable to false.

This is a revival of #4655.

Related: https://issues.redhat.com/browse/MGMT-14769
Related: https://issues.redhat.com/browse/MGMT-10678

List all the issues related to this PR

• New Feature
• Enhancement
• Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• None

How was this code tested?

• assisted-test-infra environment
• dev-scripts environment
• Reviewer's test appreciated
• Waiting for CI to do a full test run
• Manual (Elaborate on how it was tested)
• No tests needed

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see CONTRIBUTING guide)
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

[openshift-ci-robot]

@jhernand: This pull request references MGMT-14769 which is a valid jira issue.

In response to this:

The upgrade agent feature has been explicitly enabled in the SaaS environments. This patch enables it by default in all the other environments. It will still be possible to disable it setting the ENABLE_UPGRADE_AGENT environment variable to false.

This is a revival of #4655.

Related: https://issues.redhat.com/browse/MGMT-14769
Related: https://issues.redhat.com/browse/MGMT-10678

List all the issues related to this PR

• New Feature
• Enhancement
• Bug fix
• Tests
• Documentation
• CI/CD

What environments does this code impact?

• Automation (CI, tools, etc)
• Cloud
• Operator Managed Deployments
• None

How was this code tested?

• assisted-test-infra environment
• dev-scripts environment
• Reviewer's test appreciated
• Waiting for CI to do a full test run
• Manual (Elaborate on how it was tested)
• No tests needed

Checklist

• Title and description added to both, commit and PR.
• Relevant issues have been associated (see CONTRIBUTING guide)
• This change does not require a documentation update (docstring, docs, README, etc)
• Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[codecov]

Codecov Report

Merging #5276 (f5cbadb) into master (f55e7db) will increase coverage by 1.65%.
The diff coverage is n/a.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5276      +/-   ##
==========================================
+ Coverage   67.49%   69.14%   +1.65%     
==========================================
  Files         221      221              
  Lines       33016    35248    +2232     
==========================================
+ Hits        22283    24372    +2089     
- Misses       8723     8830     +107     
- Partials     2010     2046      +36     

see 10 files with indirect coverage changes

[jhernand]

/test e2e-agent-compact-ipv4

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: filanov, jhernand

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [filanov,jhernand]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jhernand]

Thanks @filanov!

[openshift-ci]

@jhernand: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.