MGMT-14040: Add log that shows event upload is running #5054
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@CrystalChun: This pull request references MGMT-14040 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
size/XS
openshift-ci
bot
added
the
approved
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5054 +/- ##
==========================================
+ Coverage 67.35% 69.65% +2.29%
==========================================
Files 214 214
Lines 31709 33858 +2149
==========================================
+ Hits 21359 23584 +2225
+ Misses 8447 8344 -103
- Partials 1903 1930 +27
|
https://issues.redhat.com/browse/MGMT-14040 If event uploading was disabled when assisted-service starts running then the only log that shows is "Event uploading is not enabled". This is confusing if event uploading is eventually enabled without restarting the service and the user won't know that the event upload is running.
|
if it will spam the log we can think of a different solution later |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CrystalChun, filanov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold Revision c22a1c0 was retested 3 times: holding |
openshift-ci
bot
added
the
do-not-merge/hold
|
/retest-required |
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
|
@CrystalChun: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
https://issues.redhat.com/browse/MGMT-14040 If event uploading was disabled when assisted-service starts running then the only log that shows is "Event uploading is not enabled". This is confusing if event uploading is eventually enabled without restarting the service and the user won't know that the event upload is running.
MGMT-14040
If event uploading was disabled when assisted-service starts running then the only log that shows is "Event uploading is not enabled". This is confusing if event uploading is eventually enabled without restarting the service and the user won't know that the event upload is running.
List all the issues related to this PR
What environments does this code impact?
How was this code tested?
Checklist
docs, README, etc)Reviewers Checklist