Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve inaccurate ODF validation message #5137

Merged
merged 1 commit into from
Apr 20, 2023

Conversation

omertuc
Copy link
Contributor

@omertuc omertuc commented Apr 20, 2023

This commit improves an inaccurate ODF validation message to make it
more clear.

The reason it's inaccurate is because our ODF code avoids the
installation disk, not "bootable" disks, the word bootable means
something else entirely. This has confused some users.

List all the issues related to this PR

  • New Feature
  • Enhancement
  • Bug fix
  • Tests
  • Documentation
  • CI/CD

What environments does this code impact?

  • Automation (CI, tools, etc)
  • Cloud
  • Operator Managed Deployments
  • None

How was this code tested?

  • assisted-test-infra environment
  • dev-scripts environment
  • Reviewer's test appreciated
  • Waiting for CI to do a full test run
  • Manual (Elaborate on how it was tested)
  • No tests needed

Checklist

  • Title and description added to both, commit and PR.
  • Relevant issues have been associated (see CONTRIBUTING guide)
  • This change does not require a documentation update (docstring, docs, README, etc)
  • Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

  • Are the title and description (in both PR and commit) meaningful and clear?
  • Is there a bug required (and linked) for this change?
  • Should this PR be backported?

This commit improves an inaccurate ODF validation message to make it
more clear.

The reason it's inaccurate is because Our ODF code avoids the
installation disk, not "bootable" disks, the word bootable means
something else entirely. This has confused some users.
@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 20, 2023
@rccrdpccl
Copy link
Contributor

/lgtm

Copy link

@sajauddin sajauddin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 20, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 20, 2023
@sajauddin sajauddin removed their assignment Apr 20, 2023
@openshift-ci
Copy link

openshift-ci bot commented Apr 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: filanov, omertuc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Apr 20, 2023

Codecov Report

Merging #5137 (525d7c4) into master (424f34a) will increase coverage by 1.10%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5137      +/-   ##
==========================================
+ Coverage   67.41%   68.51%   +1.10%     
==========================================
  Files         217      217              
  Lines       32271    33319    +1048     
==========================================
+ Hits        21754    22830    +1076     
+ Misses       8558     8502      -56     
- Partials     1959     1987      +28     
Impacted Files Coverage Δ
internal/operators/odf/odf_operator.go 62.30% <100.00%> (ø)

... and 3 files with indirect coverage changes

@omertuc
Copy link
Contributor Author

omertuc commented Apr 20, 2023

/test edge-e2e-metal-assisted-cnv

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 654a835 and 2 for PR HEAD 525d7c4 in total

@openshift-ci
Copy link

openshift-ci bot commented Apr 20, 2023

@omertuc: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot merged commit 393d62a into openshift:master Apr 20, 2023
danielerez pushed a commit to danielerez/assisted-service that referenced this pull request Oct 15, 2023
This commit improves an inaccurate ODF validation message to make it
more clear.

The reason it's inaccurate is because Our ODF code avoids the
installation disk, not "bootable" disks, the word bootable means
something else entirely. This has confused some users.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants