-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve inaccurate ODF validation message #5137
Conversation
This commit improves an inaccurate ODF validation message to make it more clear. The reason it's inaccurate is because Our ODF code avoids the installation disk, not "bootable" disks, the word bootable means something else entirely. This has confused some users.
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: filanov, omertuc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5137 +/- ##
==========================================
+ Coverage 67.41% 68.51% +1.10%
==========================================
Files 217 217
Lines 32271 33319 +1048
==========================================
+ Hits 21754 22830 +1076
+ Misses 8558 8502 -56
- Partials 1959 1987 +28
|
/test edge-e2e-metal-assisted-cnv |
@omertuc: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This commit improves an inaccurate ODF validation message to make it more clear. The reason it's inaccurate is because Our ODF code avoids the installation disk, not "bootable" disks, the word bootable means something else entirely. This has confused some users.
This commit improves an inaccurate ODF validation message to make it
more clear.
The reason it's inaccurate is because our ODF code avoids the
installation disk, not "bootable" disks, the word bootable means
something else entirely. This has confused some users.
List all the issues related to this PR
What environments does this code impact?
How was this code tested?
Checklist
docs
, README, etc)Reviewers Checklist