MGMT-15264: Block installation if no custom manifests in OCI cluster #5364
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@eliorerz: This pull request references MGMT-15264 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@eliorerz: GitHub didn't allow me to request PR reviews from the following users: eliorerz. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
size/M
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5364 +/- ##
==========================================
+ Coverage 67.53% 67.71% +0.18%
==========================================
Files 226 226
Lines 33293 33616 +323
==========================================
+ Hits 22485 22764 +279
- Misses 8774 8811 +37
- Partials 2034 2041 +7
|
|
/retest |
eliorerz
force-pushed
the
MGMT-15264_Block_installation_if_no_custom_manifests_in_OCI_cluster_as_installation_will_fail
branch
from
0a8e8a9
to
88f483b
Compare
| return ValidationSuccess, "Platform requirements satisfied" | ||
| } | ||
|
|
||
| usages, err := usage.Unmarshal(c.cluster.Cluster.FeatureUsage) |
There was a problem hiding this comment.
why we are using the feature usage for checking it and not data from the cluster? what will happen if there will be a bug in the feature usage?
eliorerz
force-pushed
the
MGMT-15264_Block_installation_if_no_custom_manifests_in_OCI_cluster_as_installation_will_fail
branch
from
88f483b
to
d9e1d3e
Compare
|
/test e2e-oci-assisted |
|
@adriengentil: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test edge-e2e-oci-assisted |
eliorerz
force-pushed
the
MGMT-15264_Block_installation_if_no_custom_manifests_in_OCI_cluster_as_installation_will_fail
branch
from
d9e1d3e
to
8037876
Compare
…chine-set operator would not go degraded due to placeholder credentials on installation. Update prism central and prism element address placeholder, so it won't be confusing on post installation steps.
eliorerz
force-pushed
the
MGMT-15264_Block_installation_if_no_custom_manifests_in_OCI_cluster_as_installation_will_fail
branch
from
8037876
to
c6978a0
Compare
|
/test edge-e2e-oci-assisted |
@eliorerz did you check it? |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eliorerz, gamli75 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/override ci/prow/edge-e2e-ai-operator-ztp-capi |
|
@eliorerz: Overrode contexts on behalf of eliorerz: ci/prow/edge-e2e-ai-operator-ztp-capi In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@eliorerz: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
eliorerz
deleted the
MGMT-15264_Block_installation_if_no_custom_manifests_in_OCI_cluster_as_installation_will_fail
branch
…chine-set operator would not go degraded due to placeholder credentials on installation. (openshift#5364) Update prism central and prism element address placeholder, so it won't be confusing on post installation steps.
…chine-set operator would not go degraded due to placeholder credentials on installation. (openshift#5364) Update prism central and prism element address placeholder, so it won't be confusing on post installation steps.
/cc @eliorerz
List all the issues related to this PR
What environments does this code impact?
How was this code tested?