MGMT-15264: Block installation if no custom manifests in OCI cluster

internal/cluster/refresh_status_preprocessor.go

@@ -201,6 +201,10 @@ func newValidations(v *clusterValidator) []validation {
 			id:        NetworksSameAddressFamilies,
 			condition: v.isNetworksSameAddressFamilies,
 		},
+		{
+			id:        PlatformRequirementsSatisfied,
+			condition: v.platformRequirementsSatisfied,
+		},
 	}
 	return ret
 }

internal/cluster/validation_id.go

@@ -33,6 +33,7 @@ const (
 	IsCnvRequirementsSatisfied          = ValidationID(models.ClusterValidationIDCnvRequirementsSatisfied)
 	IsLvmRequirementsSatisfied          = ValidationID(models.ClusterValidationIDLvmRequirementsSatisfied)
 	IsMceRequirementsSatisfied          = ValidationID(models.ClusterValidationIDMceRequirementsSatisfied)
+	PlatformRequirementsSatisfied       = ValidationID(models.ClusterValidationIDPlatformRequirementsSatisfied)
 )
 
 func (v ValidationID) Category() (string, error) {
@@ -43,7 +44,7 @@ func (v ValidationID) Category() (string, error) {
 		return "network", nil
 	case AllHostsAreReadyToInstall, SufficientMastersCount:
 		return "hosts-data", nil
-	case IsPullSecretSet:
+	case IsPullSecretSet, PlatformRequirementsSatisfied:
 		return "configuration", nil
 	case IsOdfRequirementsSatisfied, IsLsoRequirementsSatisfied, IsCnvRequirementsSatisfied, IsLvmRequirementsSatisfied, IsMceRequirementsSatisfied:
 		return "operators", nil

internal/cluster/validator.go

@@ -12,6 +12,7 @@ import (
 	"github.com/openshift/assisted-service/internal/common"
 	"github.com/openshift/assisted-service/internal/host"
 	"github.com/openshift/assisted-service/internal/network"
+	"github.com/openshift/assisted-service/internal/usage"
 	"github.com/openshift/assisted-service/models"
 	"github.com/pkg/errors"
 	"github.com/sirupsen/logrus"
@@ -400,6 +401,27 @@ func (v *clusterValidator) allHostsAreReadyToInstall(c *clusterPreprocessContext
 	return ValidationFailure, "The cluster has hosts that are not ready to install."
 }
 
+func (v *clusterValidator) platformRequirementsSatisfied(c *clusterPreprocessContext) (ValidationStatus, string) {
+	// If cluster platform type is not OCI ignore that validation
+	if c.cluster.Platform != nil && common.PlatformTypeValue(c.cluster.Platform.Type) != models.PlatformTypeOci {
+		return ValidationSuccess, "Platform requirements satisfied"
+	}
+
+	usages, err := usage.Unmarshal(c.cluster.Cluster.FeatureUsage)
+	if err != nil {
+		v.log.Errorf("platform validation failure, failed to parse feature usages, %s", err.Error())
+		return ValidationFailure, "Failed to parse feature usages"
+	}
+
+	for _, usg := range usages {
+		if usg.Name == usage.CustomManifest {
+			return ValidationSuccess, "Platform requirements satisfied"
+		}
+	}
+
+	return ValidationFailure, "The custom manifest required for Oracle Cloud Infrastructure platform integration has not been added. Add a custom manifest to continue."
+}
+
 func (v *clusterValidator) isDNSDomainDefined(c *clusterPreprocessContext) (ValidationStatus, string) {
 	if c.cluster.BaseDNSDomain != "" {
 		return ValidationSuccess, "The base domain is defined."

internal/cluster/validator_test.go

@@ -554,3 +554,61 @@ var _ = Describe("Validator tests", func() {
 	})
 
 })
+
+var _ = Describe("Platform validations", func() {
+	var (
+		validator         clusterValidator
+		preprocessContext *clusterPreprocessContext
+		clusterID         strfmt.UUID
+	)
+
+	BeforeEach(func() {
+		validator = clusterValidator{logrus.New(), nil}
+		clusterID = strfmt.UUID(uuid.New().String())
+	})
+
+	It("Should fail validation OCI cluster with no custom manifests", func() {
+		preprocessContext = &clusterPreprocessContext{hasHostsWithInventories: true}
+		preprocessContext.cluster = &common.Cluster{Cluster: models.Cluster{
+			ID: &clusterID,
+			Platform: &models.Platform{
+				IsExternal: swag.Bool(true),
+				Type:       common.PlatformTypePtr(models.PlatformTypeOci),
+			},
+			UserManagedNetworking: swag.Bool(true),
+		}}
+		status, message := validator.platformRequirementsSatisfied(preprocessContext)
+		Expect(status).To(Equal(ValidationFailure))
+		Expect(message).To(Equal("The custom manifest required for Oracle Cloud Infrastructure platform integration has not been added. Add a custom manifest to continue."))
+	})
+
+	It("Should pass platform validation on OCI cluster with no custom manifests", func() {
+		preprocessContext = &clusterPreprocessContext{hasHostsWithInventories: true}
+		preprocessContext.cluster = &common.Cluster{Cluster: models.Cluster{
+			ID: &clusterID,
+			Platform: &models.Platform{
+				IsExternal: swag.Bool(true),
+				Type:       common.PlatformTypePtr(models.PlatformTypeOci),
+			},
+			UserManagedNetworking: swag.Bool(true),
+			FeatureUsage:          "{\"Custom manifest\":{\"id\":\"CUSTOM_MANIFEST\",\"name\":\"Custom manifest\"}}",
+		}}
+		status, message := validator.platformRequirementsSatisfied(preprocessContext)
+		Expect(status).To(Equal(ValidationSuccess))
+		Expect(message).To(Equal("Platform requirements satisfied"))
+	})
+
+	It("Should pass validation if platform is baremetal", func() {
+		preprocessContext = &clusterPreprocessContext{hasHostsWithInventories: true}
+		preprocessContext.cluster = &common.Cluster{Cluster: models.Cluster{
+			ID: &clusterID,
+			Platform: &models.Platform{
+				IsExternal: swag.Bool(false),
+				Type:       common.PlatformTypePtr(models.PlatformTypeBaremetal),
+			},
+		}}
+		status, message := validator.platformRequirementsSatisfied(preprocessContext)
+		Expect(status).To(Equal(ValidationSuccess))
+		Expect(message).To(Equal("Platform requirements satisfied"))
+	})
+})

swagger.yaml

@@ -6614,6 +6614,7 @@ definitions:
       - 'lvm-requirements-satisfied'
       - 'mce-requirements-satisfied'
       - 'network-type-valid'
+      - 'platform-requirements-satisfied'
 
   logs_type:
     type: string