MGMT-15295: Fix bug in list manifests #5366
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@paul-maidment: This pull request references MGMT-15295 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
size/M
openshift-ci
bot
added
the
approved
While making a behavioural change to the way in which we list manifests openshift@689a73c A bug was introduced. This bug causes a crash when manifests are listed. This PR corrects the bug and introduces a test of the code in which the bug was found
paul-maidment
force-pushed
the
MGMT-15295
branch
from
200722f
to
edbc716
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5366 +/- ##
==========================================
+ Coverage 67.53% 67.60% +0.06%
==========================================
Files 226 226
Lines 33293 33301 +8
==========================================
+ Hits 22485 22513 +28
+ Misses 8774 8758 -16
+ Partials 2034 2030 -4
|
| @@ -172,8 +172,6 @@ func (m *Manifests) ListClusterManifestsInternal(ctx context.Context, params ope | |||
| } | |||
| if isUserManifest { | |||
| manifests = append(manifests, &models.Manifest{FileName: filename, Folder: folder}) | |||
| } else { | |||
There was a problem hiding this comment.
regarding line 154 - if the cluster doesn't exist please replace the "Object not found" message and use something like https://github.com/openshift/assisted-service/blob/master/internal/bminventory/inventory.go#L1535
|
/cherry-pick cloud_hotfix_releases |
|
@osherdp: once the present PR merges, I will cherry-pick it on top of cloud_hotfix_releases in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: filanov, javipolo, paul-maidment The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retitle MGMT-15295: Fix bug in list manifests |
openshift-ci
bot
changed the title
|
/test e2e-agent-compact-ipv4 |
|
/retest |
|
There's probably a condition affecting all sorts of jobs: https://redhat-internal.slack.com/archives/CBN38N3MW/p1689700194662809 |
|
/retest |
|
@paul-maidment: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@osherdp: new pull request created: #5368 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
While making a behavioural change to the way in which we list manifests openshift@689a73c A bug was introduced. This bug causes a crash when manifests are listed. This PR corrects the bug and introduces a test of the code in which the bug was found
While making a behavioural change to the way in which we list manifests openshift@689a73c A bug was introduced. This bug causes a crash when manifests are listed. This PR corrects the bug and introduces a test of the code in which the bug was found
While making a behavioural change to the way in which we list manifests openshift@689a73c A bug was introduced. This bug causes a crash when manifests are listed. This PR corrects the bug and introduces a test of the code in which the bug was found
While making a behavioural change to the way in which we list manifests 689a73c A bug was introduced. This bug causes a crash when manifests are listed.
This PR corrects the bug and introduces a test of the code in which the bug was found
List all the issues related to this PR
What environments does this code impact?
How was this code tested?
Checklist
docs, README, etc)Reviewers Checklist